Found by the clang analyzer:
command.c:934:16: warning: Assigned value is always the same as the existing value
for (i = 0, p = iov->iov_base; p < end; i++)
~ ^ ~~~~~~~~~~~~~
clang is right: A couple of lines before the for loop we set p to
iov->iov_base and do not modify it.
if (ret < 0)
goto out;
end = iov->iov_base + iov->iov_len;
- for (i = 0, p = iov->iov_base; p < end; i++)
+ for (i = 0; p < end; i++)
p += strlen(p) + 1;
cc->argc = i;
cc->argv = para_malloc((cc->argc + 1) * sizeof(char *));