Add wrapper for isspace().

This avoids

	warning: subscript has type `char'

on netbsd.

diff --git a/audiod.c b/audiod.c
index b8c072d52cdc80ae48d3c56cbf065cff2d80e457..3bac70ade87f7ba644dd8f5af2a68c1740976bd2 100644 (file)
--- a/audiod.c
+++ b/audiod.c
@@ -119,7 +119,7 @@ int get_audio_format_num(char *name)
 {
        int i;
 
-       while (isspace(*name))
+       while (para_isspace(*name))
                name++;
        FOR_EACH_AUDIO_FORMAT(i)
                if (!strcmp(name, audio_formats[i]))

diff --git a/mp3_afh.c b/mp3_afh.c
index fe174ea89276dc4298ed9c86b7d0c60ee6eb0624..f5fc7113d14bed295f862de00f5d5c093941d47d 100644 (file)
--- a/mp3_afh.c
+++ b/mp3_afh.c
@@ -163,7 +163,7 @@ static void write_info_str(struct afh_info *afhi)
 static char *unpad(char *string)
 {
        char *pos = string + strlen(string) - 1;
-       while (isspace(pos[0]))
+       while (para_isspace(pos[0]))
                (pos--)[0] = 0;
        return string;
 }

diff --git a/para.h b/para.h
index 9ee318e54e4cb1dae4798f41d60c9187dde517b2..0cb1538d2725fd79c7de01871bcb617bcd73c706 100644 (file)
--- a/para.h
+++ b/para.h
@@ -217,3 +217,18 @@ static inline long int para_random(unsigned max)
 
 /** Get the size of an array */
 #define ARRAY_SIZE(x) (sizeof(x) / sizeof((x)[0]))
+
+/**
+ * Wrapper for isspace.
+ * NetBSD needs this.
+ */
+/*
+ * The values should be cast to an unsigned char first, then to int.
+ * Why? Because the isdigit (as do all other is/to functions/macros)
+ * expect a number from 0 upto and including 255 as their (int) argument.
+ * Because char is signed on most systems, casting it to int immediately
+ * gives the functions an argument between -128 and 127 (inclusive),
+ * which they will use as an array index, and which will thus fail
+ * horribly for characters which have their most significant bit set.
+ */
+#define para_isspace(c) isspace((int)(unsigned char)(c))