]> git.tue.mpg.de Git - paraslash.git/commitdiff
mysql.c: Fix boolean logig bug
authorAndre Noll <maan@systemlinux.org>
Tue, 19 Dec 2006 17:30:51 +0000 (18:30 +0100)
committerAndre Noll <maan@systemlinux.org>
Tue, 19 Dec 2006 17:30:51 +0000 (18:30 +0100)
Found by davej's findbugs.pl script.

Hard to spot for the human eye.

mysql_selector.c

index 9363dba45c0b7a031adf5f9e0b64326243ee0b1a..7a3b0a7d9c5b99d55c3e094ed497126805f927f2 100644 (file)
@@ -1502,7 +1502,7 @@ static int com_mv(__a_unused int fd, int argc, char *argv[])
        ret = -E_ESCAPE;
        ebn1 = escaped_basename(argv[1]);
        ebn2 = escaped_basename(argv[2]);
-       if (!ebn1 || !ebn2 | !*ebn1 || !*ebn2)
+       if (!ebn1 || !ebn2 || !*ebn1 || !*ebn2)
                goto out;
        ret = -E_MYSQL_SYNTAX;
        if (!strcmp(ebn1, ebn2))