]> git.tue.mpg.de Git - paraslash.git/commitdiff
aac_afh.c: Simplify atom_cmp().
authorAndre Noll <maan@systemlinux.org>
Mon, 16 Dec 2013 17:44:12 +0000 (18:44 +0100)
committerAndre Noll <maan@tuebingen.mpg.de>
Mon, 28 Dec 2015 18:50:50 +0000 (18:50 +0000)
It's pointless to compare the buffer byte by byte. Just use memcmp(3)
instead.

aac_afh.c

index 04d74e8ed91ce1c54d67f675d301c8a139c2f6c3..5018e2f4b09b7d0afce6b27ef88eb7dd2ce0c374 100644 (file)
--- a/aac_afh.c
+++ b/aac_afh.c
@@ -46,17 +46,7 @@ static int aac_find_stsz(unsigned char *buf, size_t buflen, off_t *skip)
 
 static int atom_cmp(const unsigned char *buf1, const char *buf2)
 {
-       const unsigned char *b2 = (unsigned char *)buf2;
-
-       if (buf1[0] != b2[0])
-               return 1;
-       if (buf1[1] != b2[1])
-               return 1;
-       if (buf1[2] != b2[2])
-               return 1;
-       if (buf1[3] != b2[3])
-               return 1;
-       return 0;
+       return memcmp(buf1, buf2, 4)? 1 : 0;
 }
 
 static int read_atom_header(unsigned char *buf, uint64_t *subsize, unsigned char type[5])