From: Andre Noll <maan@tuebingen.mpg.de>
Date: Mon, 9 Aug 2021 22:19:56 +0000 (+0200)
Subject: mp4: Remove pointless casts in create_ilst().
X-Git-Tag: v0.7.1~7^2~109
X-Git-Url: http://git.tue.mpg.de/?a=commitdiff_plain;h=0774bde6447b529a1b607e37a72b5d6cd124be42;p=paraslash.git

mp4: Remove pointless casts in create_ilst().

They have no effect because membuffer_write_int16_tag() takes a
unit16_t value anyway.
---

diff --git a/mp4.c b/mp4.c
index 3765d813..ae248899 100644
--- a/mp4.c
+++ b/mp4.c
@@ -1835,8 +1835,7 @@ static uint32_t create_ilst(const struct mp4ff_metadata *data, void **out_buffer
 					  myatoi(discnumber_ptr),
 					  myatoi(totaldiscs_ptr));
 	if (tempo_ptr)
-		membuffer_write_int16_tag(buf, "tmpo",
-					  (uint16_t) myatoi(tempo_ptr));
+		membuffer_write_int16_tag(buf, "tmpo", myatoi(tempo_ptr));
 
 	if (genre_ptr) {
 		uint32_t index = meta_genre_to_index(genre_ptr);
@@ -1844,8 +1843,7 @@ static uint32_t create_ilst(const struct mp4ff_metadata *data, void **out_buffer
 			membuffer_write_std_tag(buf, "©gen",
 						genre_ptr);
 		else
-			membuffer_write_int16_tag(buf, "gnre",
-						  (uint16_t) index);
+			membuffer_write_int16_tag(buf, "gnre", index);
 	}
 	for (metaptr = 0; metaptr < data->count; metaptr++) {
 		if (!mask[metaptr]) {