From: Andre Noll <maan@systemlinux.org>
Date: Sun, 17 Feb 2008 20:54:02 +0000 (+0100)
Subject: daemon.c: Minor logging impreovments.
X-Git-Tag: v0.3.1~9
X-Git-Url: http://git.tue.mpg.de/?a=commitdiff_plain;h=4594318afeb3d667eeaedf9c84a451ba83d0a638;p=paraslash.git

daemon.c: Minor logging impreovments.
---

diff --git a/daemon.c b/daemon.c
index c790c17b..bb75478a 100644
--- a/daemon.c
+++ b/daemon.c
@@ -88,7 +88,7 @@ void close_log(FILE* logfile)
 {
 	if (!logfile)
 		return;
-	PARA_INFO_LOG("%s", "closing logfile\n");
+	PARA_INFO_LOG("closing logfile\n");
 	fclose(logfile);
 }
 
@@ -126,27 +126,28 @@ void para_drop_privileges(const char *username, const char *groupname)
 	if (groupname) {
 		struct group *g = getgrnam(groupname);
 		if (!g) {
-			PARA_EMERG_LOG("failed to get group %s\n", groupname);
+			PARA_EMERG_LOG("failed to get group %s: %s\n",
+				groupname, strerror(errno));
 			exit(EXIT_FAILURE);
 		}
 		if (setgid(g->gr_gid) < 0) {
-			PARA_EMERG_LOG("failed to set group id %d (%s)\n",
+			PARA_EMERG_LOG("failed to set group id %d: %s\n",
 				(int)g->gr_gid, strerror(errno));
 			exit(EXIT_FAILURE);
 		}
 	}
 	if (!username) {
-		PARA_EMERG_LOG("%s", "root privileges, but no user option given\n");
+		PARA_EMERG_LOG("root privileges, but no user option given\n");
 		exit(EXIT_FAILURE);
 	}
 	tmp = para_strdup(username);
 	p = getpwnam(tmp);
 	free(tmp);
 	if (!p) {
-		PARA_EMERG_LOG("%s", "no such user\n");
+		PARA_EMERG_LOG("%s: no such user\n", username);
 		exit(EXIT_FAILURE);
 	}
-	PARA_INFO_LOG("%s", "dropping root privileges\n");
+	PARA_INFO_LOG("dropping root privileges\n");
 	setuid(p->pw_uid);
 	PARA_DEBUG_LOG("uid: %d, euid: %d\n", (int)getuid(), (int)geteuid());
 }