From: Andre Noll <maan@tuebingen.mpg.de>
Date: Sun, 5 Apr 2015 14:12:42 +0000 (+0000)
Subject: com_mvatt(): Return negative on errors
X-Git-Tag: v0.5.6~94^2~17
X-Git-Url: http://git.tue.mpg.de/?a=commitdiff_plain;h=a3ea3e74e59bc6cff452542ff9b422af647c189d;p=paraslash.git

com_mvatt(): Return negative on errors
---

diff --git a/attribute.c b/attribute.c
index 82ac4dac..70e35ae5 100644
--- a/attribute.c
+++ b/attribute.c
@@ -328,24 +328,19 @@ static int com_mvatt_callback(int fd, const struct osl_object *query)
 	ret = osl(osl_update_object(attribute_table, row, ATTCOL_NAME, &obj));
 out:
 	if (ret < 0)
-		para_printf(&pb, "%s\n", para_strerror(-ret));
+		para_printf(&pb, "cannot rename %s to %s\n", old, new);
 	else
 		afs_event(ATTRIBUTE_RENAME, &pb, NULL);
 	flush_and_free_pb(&pb);
-	return 0;
+	return ret;
 }
 
 int com_mvatt(struct command_context *cc)
 {
-	int ret;
-
 	if (cc->argc != 3)
 		return -E_ATTR_SYNTAX;
-	ret = send_standard_callback_request(cc->argc - 1, cc->argv + 1,
+	return send_standard_callback_request(cc->argc - 1, cc->argv + 1,
 		com_mvatt_callback, afs_cb_result_handler, cc);
-	if (ret < 0)
-		send_strerror(cc, -ret);
-	return ret;
 }
 
 /** Data passed to the action handler of com_rmatt(). */