]>
git.tue.mpg.de Git - paraslash.git/log
Andre Noll [Tue, 25 Sep 2007 12:57:09 +0000 (14:57 +0200)]
com_check(): Implement mood checking.
Andre Noll [Tue, 25 Sep 2007 12:16:14 +0000 (14:16 +0200)]
make get_playlist_data() generic.
Other blob types might use an analogous function as well, so introduce
blob_get_name_and_def_by_row() in blob.c, and use some preprocessor
magic to define such a function for each blob type.
Change all users of get_playlist_data() to use the new
pl_blob_get_name_and_def_by_row() and remove get_playlist_data().
Andre Noll [Tue, 25 Sep 2007 11:02:26 +0000 (13:02 +0200)]
mood.c: Rename mood_loop() to load_mood_loop_func().
And add a comment that describes why this function returns negative on success,
and positive on errors.
Andre Noll [Tue, 25 Sep 2007 10:51:38 +0000 (12:51 +0200)]
Update Doxyfile to doxygen-1.5.3.
Automatic update, done with doxygen -u.
Andre Noll [Tue, 25 Sep 2007 09:53:58 +0000 (11:53 +0200)]
afs: Move some ls-related stuff from afs.h to aft.c.
Also, add GPL header and documentation of struct afs_info to afs.h.
Andre Noll [Tue, 25 Sep 2007 09:39:23 +0000 (11:39 +0200)]
More mood cleanups.
- Avoid use of global current_mood pointer where possible.
- Change name of non-static functions that use the current mood pointer:
mood_open() -> change_current_mood()
mood_close() -> close_current_mood()
mood_reload() -> reload_current_mood()
Andre Noll [Tue, 25 Sep 2007 08:59:56 +0000 (10:59 +0200)]
compute_mood_score(): Add additional mood * parameter.
Thid reduces the use of the global current_mood pointer.
Andre Noll [Tue, 25 Sep 2007 08:53:52 +0000 (10:53 +0200)]
compute_mood_score(): Rename "row" parameter to "aft_row".
Andre Noll [Tue, 25 Sep 2007 08:47:38 +0000 (10:47 +0200)]
mood.c: Use current_mood as data pointer for parse_mood_line().
Andre Noll [Tue, 25 Sep 2007 08:46:00 +0000 (10:46 +0200)]
mood.c: Add GPL header.
Andre Noll [Tue, 25 Sep 2007 08:41:01 +0000 (10:41 +0200)]
mood.c: Change type of rows from "void *" to "struct osl_row *".
Andre Noll [Tue, 25 Sep 2007 08:40:23 +0000 (10:40 +0200)]
score.c: Remove an unused function declaration.
Andre Noll [Mon, 24 Sep 2007 19:26:17 +0000 (21:26 +0200)]
afs.cmd: Add documentation of the remaining commands.
And improve the formating of command options.
Andre Noll [Mon, 24 Sep 2007 16:10:36 +0000 (18:10 +0200)]
blob.c: Implement pattern matching.
Most of the blob functions now take a pattern list as arguments,
and the function does the job for all blobs that match any given
pattern in the list.
The only exceptions are addblob and mvblob where a pattern list
does not make sense.
Andre Noll [Mon, 24 Sep 2007 16:08:13 +0000 (18:08 +0200)]
Make rbtree_loop() and rbtree_loop_reverse() safe against removal of an entry.
Also, fix the documentation of osl_rbtree_loop() which claimed that an
osl_rbtree_loop_func takes two void pointers which is not true any more.
Andre Noll [Mon, 24 Sep 2007 06:54:16 +0000 (08:54 +0200)]
aft.c: Add GPL header.
Andre Noll [Sun, 23 Sep 2007 20:38:54 +0000 (22:38 +0200)]
afs.c: Avoid noisy log message.
para_server regularly sends SIGUSR1 to all of its children. afs
just ignores that signal, so only print a log message if a signal
different from SIGUSR1 was caught.
Andre Noll [Sun, 23 Sep 2007 20:20:54 +0000 (22:20 +0200)]
afs.cmd: Add documentation of all blob commands.
Andre Noll [Sun, 23 Sep 2007 20:20:24 +0000 (22:20 +0200)]
command_util.sh: Fix man output for templates.
Andre Noll [Sun, 23 Sep 2007 18:42:31 +0000 (20:42 +0200)]
afs.c: Fix documentation of stdin_command().
It doesn't read from stdin but from the given fd.
Andre Noll [Sun, 23 Sep 2007 18:35:26 +0000 (20:35 +0200)]
stdin.h, stdout.h: Trivial documentation cleanup.
Andre Noll [Sun, 23 Sep 2007 18:29:56 +0000 (20:29 +0200)]
stdout.[ch]: Make two functions static.
Andre Noll [Sun, 23 Sep 2007 18:28:25 +0000 (20:28 +0200)]
stdin.[ch]: Make two functions static.
Andre Noll [Sun, 23 Sep 2007 18:25:54 +0000 (20:25 +0200)]
stdin.c: Fix a typo in documentation.
Andre Noll [Sun, 23 Sep 2007 17:34:17 +0000 (19:34 +0200)]
Implement check for invalid playlist entries.
Also some minor improvements for the audio file table checks.
Andre Noll [Sun, 23 Sep 2007 15:56:39 +0000 (17:56 +0200)]
playlist.c: Cleanups.
Avoid using the global playlist variable where possible. Change the name of the
global static playlist struct to current_playlist.
Andre Noll [Sun, 23 Sep 2007 15:17:45 +0000 (17:17 +0200)]
Implement check command.
Currently it only checks the audio file table. Checking moods
and playlists will be implemented in a subsequent patch.
Andre Noll [Sat, 22 Sep 2007 15:45:09 +0000 (17:45 +0200)]
Add convert_0.2-0.3.sh.
Andre Noll [Sat, 22 Sep 2007 15:43:50 +0000 (17:43 +0200)]
afs.cmd: Add documentation of addatt, touch.
Andre Noll [Sat, 22 Sep 2007 12:48:45 +0000 (14:48 +0200)]
net.c: Fix a typo and improve send_bin_buffer() docu.
Andre Noll [Sat, 22 Sep 2007 12:46:07 +0000 (14:46 +0200)]
afs.h: Change the prototype of stdin_command() to refelct reality.
Andre Noll [Sat, 22 Sep 2007 12:45:21 +0000 (14:45 +0200)]
Fix some bugs in blob handling.
- make fd2buf() decrypt the received data.
- stdin_command() has to read from the socket fd rather than from stdin.
Moreover, it must send the AWAITING_DATA_MSG to the client.
- com_catblob() really needs to use send_bin_buffer() rather than send_buffer().
- com_addblob() has to pass the socket fd to stdin_command().
Andre Noll [Sat, 22 Sep 2007 11:34:12 +0000 (13:34 +0200)]
Fix com_lsblob().
In case no output was produced, don't access output data and don't free it.
Andre Noll [Sat, 22 Sep 2007 08:18:33 +0000 (10:18 +0200)]
Fix off-by-one in com_rmatt().
Andre Noll [Fri, 21 Sep 2007 09:19:38 +0000 (11:19 +0200)]
fsck.c: Fix a double free bug.
Andre Noll [Fri, 21 Sep 2007 09:01:13 +0000 (11:01 +0200)]
Merge commit 'remotes/meins/v0.3' into v0.3
Andre Noll [Thu, 20 Sep 2007 21:44:31 +0000 (23:44 +0200)]
Make para_fsck work without specifying tables.
Also, move some fd related functions from osl.c to fd.c and
introduce para_opendir().
Andre Noll [Wed, 19 Sep 2007 21:12:52 +0000 (23:12 +0200)]
Remove unused -E_LSTAT.
Andre Noll [Wed, 19 Sep 2007 21:09:41 +0000 (23:09 +0200)]
osl.c for_each_file_in_dir(): Move struct stat to inner loop.
Andre Noll [Wed, 19 Sep 2007 20:41:15 +0000 (22:41 +0200)]
Gengetoptify para_fsck.
Basic fsck works, but some options are not yet implemented,
and dump is busted.
Andre Noll [Wed, 19 Sep 2007 17:14:10 +0000 (19:14 +0200)]
error.h: Add remaining error messages.
Andre Noll [Wed, 19 Sep 2007 17:07:36 +0000 (19:07 +0200)]
aft.c: Fix a nasty memory corruption bug in afs_ls on 64 bit archs.
That was pretty hard to spot but obvious once found.
Andre Noll [Wed, 19 Sep 2007 06:21:24 +0000 (08:21 +0200)]
Add para_fsck.
Andre Noll [Tue, 18 Sep 2007 07:33:46 +0000 (09:33 +0200)]
Add small version of the earthshaking new logo.
Andre Noll [Mon, 17 Sep 2007 18:24:46 +0000 (20:24 +0200)]
The earthshaking new logo.
Andre Noll [Mon, 17 Sep 2007 17:08:58 +0000 (19:08 +0200)]
Revert "string.c: Use $HOME to get the home directory."
This reverts commit
379a2724984d903b7be8981a85b6cc82cab6ea90 .
It doesn't play well with the -u option of para_server.
Andre Noll [Sat, 15 Sep 2007 22:36:13 +0000 (00:36 +0200)]
server/afs: Close an unused file descriptor.
And mark file descriptors used for select() as non-blocking.
Andre Noll [Sat, 15 Sep 2007 21:33:52 +0000 (23:33 +0200)]
Some documentation fixes.
MAke doxygen happy again and add documentation for com_setatt().
Andre Noll [Sat, 15 Sep 2007 21:08:23 +0000 (23:08 +0200)]
osl.c: Rename verify_basename() to verify_name().
It's actually used for verifying table names and column names.
Andre Noll [Sat, 15 Sep 2007 21:05:29 +0000 (23:05 +0200)]
osl: Rename struct row.id to row.num.
Andre Noll [Sat, 15 Sep 2007 20:58:16 +0000 (22:58 +0200)]
aft.c: Kill global variable "now".
Andre Noll [Sat, 15 Sep 2007 20:22:33 +0000 (22:22 +0200)]
Replace void *row by struct osl_row *row.
Also, make some functions in aft.c static.
Andre Noll [Sat, 15 Sep 2007 20:14:31 +0000 (22:14 +0200)]
attribute.c: Major cleanup and fixes.
- Implement callback for the broken lsatt command.
- Add documentation and GPL header.
- Fix a nasty bug in com_setatt_callback().
Andre Noll [Sat, 15 Sep 2007 20:11:36 +0000 (22:11 +0200)]
Add more error descriptions.
Andre Noll [Sat, 15 Sep 2007 20:10:08 +0000 (22:10 +0200)]
afs.cmd: Add documentation for lsatt.
Andre Noll [Sat, 15 Sep 2007 20:09:31 +0000 (22:09 +0200)]
command.c: Fix a bug in get_cmd_ptr().
Caused handler to segfault if an invalid command was given.
Andre Noll [Sat, 15 Sep 2007 17:42:29 +0000 (19:42 +0200)]
replace para_connect() by PARA_CONNECT.
PARA_CONNECT is a macro which works for all three socket address types
used in paraslash (sockaddr_in, sockaddr, sockaddr_un) and which does
not need a length parameter.
Change all instances of connect() and para_connect() to use PARA_CONNECT().
Andre Noll [Sat, 15 Sep 2007 16:51:57 +0000 (18:51 +0200)]
time.c: Add GPL header and improve documentation.
Andre Noll [Sat, 15 Sep 2007 16:32:32 +0000 (18:32 +0200)]
Invalidate table pointers on shutdown.
This caused a segfault when com_init() was invoked twice because
osl was trying to close an already closed table.
Also, add a bunch of error descriptions.
Andre Noll [Sat, 15 Sep 2007 14:01:20 +0000 (16:01 +0200)]
Rename osl index entry stuff.
struct osl_table: index_entry_size -> row_index_size
get_index_entry_start -> get_row_index
get_index_entry -> get_cell_index
update_index_entry -> update_cell_index
Andre Noll [Sat, 15 Sep 2007 13:27:48 +0000 (15:27 +0200)]
loglevel adjustments.
Andre Noll [Sat, 15 Sep 2007 13:26:42 +0000 (15:26 +0200)]
error.h: Add error message for E_NO_MATCH.
Andre Noll [Sat, 15 Sep 2007 13:12:59 +0000 (15:12 +0200)]
osl.c: Fix a bug in osl_update_object().
In case a mapped column is being updated, we have to unmap the
thing before appending to the data file.
Andre Noll [Sat, 15 Sep 2007 08:41:48 +0000 (10:41 +0200)]
com_add(): Add missing return statement.
Duplicates were added twice in force mode.
Andre Noll [Sat, 15 Sep 2007 07:50:14 +0000 (09:50 +0200)]
Fix the privious assertion().
It's OK to ask for the name of an audio format id < 0, as id -1 is used for
"currently no audio file is open". So allow this case, and fix the upper bound
which was off by one while we're at it.
Andre Noll [Sat, 15 Sep 2007 07:39:18 +0000 (09:39 +0200)]
audio_format_name(): Add an assert().
The paraslash code should never request the name of an audio format
with invalid id. Introduce the ARRAY_SIZE macro to get the proper
upper bound for the number of supported audio formats.
Andre Noll [Sat, 15 Sep 2007 07:29:18 +0000 (09:29 +0200)]
ogg_afh.c: Store the bitrate in KHz rather than in Hz.
The other audio format handlers also do it that way.
Andre Noll [Sat, 15 Sep 2007 07:16:05 +0000 (09:16 +0200)]
command.c: Fix om_help().
It segfaulted due to a missing return statement.
Andre Noll [Sat, 15 Sep 2007 07:15:09 +0000 (09:15 +0200)]
command.c: Increase maximal command length.
4096 is really short if you want to pass lots of filenames.
Andre Noll [Fri, 14 Sep 2007 20:10:28 +0000 (22:10 +0200)]
More loglevel adjustments.
Andre Noll [Fri, 14 Sep 2007 19:59:58 +0000 (21:59 +0200)]
afs.cmd: Add documentation of com_afs_ls.
Andre Noll [Fri, 14 Sep 2007 19:59:32 +0000 (21:59 +0200)]
com_afs_ls(): Fix output width of duration.
Andre Noll [Fri, 14 Sep 2007 17:51:08 +0000 (19:51 +0200)]
loglevel adjustments.
Adding many audio files was way to verbose..
Andre Noll [Fri, 14 Sep 2007 15:41:31 +0000 (17:41 +0200)]
afs: com_add() fixes and improvements.
- Simplify verify_path()
- make com_add() accept paths that end with a slash.
- add_one_audio_file() _always_ returns success.
Andre Noll [Fri, 14 Sep 2007 09:14:41 +0000 (11:14 +0200)]
rc4: Round up output buffer size.
valgrind indicated that RC4() writes beyond the end of the output buffer which
was was of the same size than the input buffer. Workaround this by rounding up
the output buffer size to a multiple of 8.
Andre Noll [Thu, 13 Sep 2007 21:06:39 +0000 (23:06 +0200)]
aac_afh.c: Fix serious memory leak.
Ooops. We forgot to close the AAC decoder handle...
Andre Noll [Thu, 13 Sep 2007 19:55:46 +0000 (21:55 +0200)]
Fix com_add segfault.
We call free(obj.data) unconditionally on errors, but is is not set to NULL.
Also, return always success in add_one_audio_file() in order to continue the
loop.
Andre Noll [Thu, 13 Sep 2007 19:53:32 +0000 (21:53 +0200)]
ogg_afh.c: Fix a memory leak.
In an non-ogg file is passed to the ogg audio format handler, such that the
initial ogg_sync_pageout() fails, the old code leaked the memory which was
allocated for the stream_in and the stream_out pointers.
Andre Noll [Thu, 13 Sep 2007 17:09:24 +0000 (19:09 +0200)]
com_add: Minor improvements.
Continue if an audio file could not be added and print proper error
message in case of errors.
Andre Noll [Wed, 12 Sep 2007 21:43:16 +0000 (23:43 +0200)]
aft.c: Fix com_add().
callbacks shall return zero or negative, if no result is provided. So let
com_ls_callback() return zero if no match was found, or if the audio file table
does not contain any entries. Check for ret > 0 in com_add() instead of ret >=
0, i.e. don't use the result pointer if ret is zero.
Andre Noll [Wed, 12 Sep 2007 21:39:15 +0000 (23:39 +0200)]
afs.c: Fix com_init().
It didn't use callbacks which worked before the paraslash merge only.
Andre Noll [Wed, 12 Sep 2007 17:46:03 +0000 (19:46 +0200)]
afs.c: Add log message, cast sizeof().
In case the local socket could not be created, we really should
tell the user that fact.
The other change in this patch is casting sizeof() to unsigned
long which shuts gcc up on both i386 and x86_64.
Andre Noll [Wed, 12 Sep 2007 11:36:20 +0000 (13:36 +0200)]
string.c: Use $HOME to get the home directory.
This is actually simpler than using getpwuid(), and it shuts up a valgrind
warning as well.
Andre Noll [Wed, 12 Sep 2007 09:23:54 +0000 (11:23 +0200)]
vss_init(): Use FOR_EACH_AUDIO_FORMAT() instead of open coding the loop.
Fixes a segfault on startup in case not all three audio formats are supported.
Andre Noll [Mon, 10 Sep 2007 21:10:19 +0000 (23:10 +0200)]
Fix afs_shutdown().
Unregister tasks as soon as we catch a terminating signal and call
afs_shutdown() when sched() returns.
Andre Noll [Mon, 10 Sep 2007 21:08:35 +0000 (23:08 +0200)]
osl.c: Dereference pointer _after_ checking for NULL.
Andre Noll [Mon, 10 Sep 2007 19:52:00 +0000 (21:52 +0200)]
afs: Replace DATABASE_DIR by a runtime config option.
Also, split afs_init() into two parts: The new open_afs_tables() that
does what its name suggests and the remaining part that initializes
the scheduler.
Andre Noll [Mon, 10 Sep 2007 00:56:46 +0000 (02:56 +0200)]
afs: Minor improvements and fixes.
- Fix audio format handler output of ls -v.
- add_one_audio_file(): Write log messages to the client fd instead of
para_server's logfile.
Andre Noll [Mon, 10 Sep 2007 00:53:52 +0000 (02:53 +0200)]
Fix two typos in documentation.
Andre Noll [Mon, 10 Sep 2007 00:53:12 +0000 (02:53 +0200)]
Doxyfile: set EXTRACT_ALL to yes.
Otherwise doxygen gives zillions of warnings.
Andre Noll [Mon, 10 Sep 2007 00:52:09 +0000 (02:52 +0200)]
Add a new style file.
For v0.3 the outfit should at least change a bit ;)
Andre Noll [Mon, 10 Sep 2007 00:05:15 +0000 (02:05 +0200)]
afs com_add(): Recognize also audio formats different from mp3.
This required adding two more callbacks: path_brother_callback() and
hash_sister_callback(). These are called from add_one_audio_file()
which runs from handler context and can thus not access the database
directly.
Andre Noll [Sun, 9 Sep 2007 17:29:26 +0000 (19:29 +0200)]
Change the type of the argv argument of all commands.
The new type,
char * const * const argv
is what the exec functions also take. This avoids some
warnings.
Andre Noll [Sun, 9 Sep 2007 15:24:13 +0000 (17:24 +0200)]
Fix some format string warnings on x86_64.
Andre Noll [Sun, 9 Sep 2007 15:16:43 +0000 (17:16 +0200)]
Add documentation for com_add().
Andre Noll [Sun, 9 Sep 2007 15:16:23 +0000 (17:16 +0200)]
Makefile.in: Add afs_command_list.man to the list of server commands.
Andre Noll [Sun, 9 Sep 2007 12:56:41 +0000 (14:56 +0200)]
vss.c: Introduce get_audio_file_info().
This is going to be used from within aft's com_add() which ATM only
supports mp3.
Andre Noll [Sun, 9 Sep 2007 12:47:59 +0000 (14:47 +0200)]
afh.h: Kill unused SUPPORTED_AUDIO_FORMATS_ARRAY.
Andre Noll [Sun, 9 Sep 2007 11:15:52 +0000 (13:15 +0200)]
afs.c: Kill unused struct callback_data.
Andre Noll [Sun, 9 Sep 2007 11:13:03 +0000 (13:13 +0200)]
Add a .gitignore file.