]>
git.tue.mpg.de Git - paraslash.git/log
Andre Noll [Sun, 25 Nov 2007 13:48:40 +0000 (14:48 +0100)]
Rename init_tcp_socket() to tcp_listen() and further net.c cleanups.
Cleanups consist in the following:
- get rid of setserversockopts(). It had only one caller
within net.c, so incorporate it into tcp_listen().
- Kill E_BIND, E_LISTEN, E_SETSOCKOPT and E_SOCKET. Return
converted errno instead.
Andre Noll [Sun, 25 Nov 2007 12:36:37 +0000 (13:36 +0100)]
Introduce tcp_connect().
This replaces get_host_info(). The two callers of the latter,
client_connect() and http_recv_open(), did exactly the same, namely
initializing a struct sockaddr_in which was then used for PARA_CONNECT().
So move this common code to tcp_connect(). Additional benefit of this
is that the only remaining callers of init_sockaddr() are in net.c, so
make this function static.
Andre Noll [Sun, 25 Nov 2007 11:25:37 +0000 (12:25 +0100)]
net.c: Cosmetics.
Andre Noll [Sun, 25 Nov 2007 11:25:08 +0000 (12:25 +0100)]
Kill E_ACCEPT.
Andre Noll [Sun, 25 Nov 2007 11:08:24 +0000 (12:08 +0100)]
Get rid of E_SEND.
This patch also simplifies sendall() a bit and fixes two bugs in
add_one_audio_file():
- If the check for existence of a hash sister failed, we missed
to unmap the audio file.
- If an error occurred we send out a message to the client. If
this message can not be sent (because the client terminated
the connection) we returned success anyway and happily
tried to add the next audio file.
Some documentation improvements as well.
Andre Noll [Sun, 25 Nov 2007 09:59:29 +0000 (10:59 +0100)]
Get rid of E_RECV.
recv_bin_buffer() returns the converted errno on errors.
So there's no point in having a paraslash error number for recv errors.
Andre Noll [Sat, 24 Nov 2007 23:10:19 +0000 (00:10 +0100)]
Minor doxygen improvements.
Andre Noll [Sat, 24 Nov 2007 22:44:25 +0000 (23:44 +0100)]
ogg_afh.c: Increase eof timeval.
Andre Noll [Sat, 24 Nov 2007 22:26:11 +0000 (23:26 +0100)]
gui: Reorder display of status items.
Andre Noll [Sat, 24 Nov 2007 22:25:33 +0000 (23:25 +0100)]
gui.c: Handle empty status items properly.
Andre Noll [Sat, 24 Nov 2007 22:25:01 +0000 (23:25 +0100)]
gui.c: Cosmetics.
Andre Noll [Sat, 24 Nov 2007 19:10:15 +0000 (20:10 +0100)]
gui.c: Increase numbers of color pairs not related to themes.
So that they do not overlap with status items color pairs.
Andre Noll [Sat, 24 Nov 2007 13:31:21 +0000 (14:31 +0100)]
Rename mood_method "name_like" to "path_matches".
Andre Noll [Sat, 24 Nov 2007 13:19:21 +0000 (14:19 +0100)]
Fix rename detection.
If a file is renamed and re-added the old code would segfault because of
a NULL pointer dereference in save_chunk_table(). Fix is trivial.
Andre Noll [Sat, 24 Nov 2007 12:01:45 +0000 (13:01 +0100)]
com_lsblob(): Fix sorting order.
Andre Noll [Sat, 24 Nov 2007 11:00:25 +0000 (12:00 +0100)]
Merge commit 'remotes/fml/master'
Andre Noll [Fri, 23 Nov 2007 17:17:19 +0000 (18:17 +0100)]
Define XOPEN_SOURCE and __EXTENSIONS__ on Solaris.
These are needed for passing fd through a socket.
Andre Noll [Fri, 23 Nov 2007 17:15:52 +0000 (18:15 +0100)]
Don't garbage-collect sections.
This does not work on Solaris, NetBSD and MacOS. Leave it in as
a comment though.
Andre Noll [Fri, 23 Nov 2007 10:15:42 +0000 (11:15 +0100)]
Rename mark_fd_nonblock() to mark_fd_nonblocking().
Just to be consistent with mark_fd_blocking().
Andre Noll [Fri, 23 Nov 2007 10:11:42 +0000 (11:11 +0100)]
Rename sched() to schedule().
We already have struct sched..
Andre Noll [Fri, 23 Nov 2007 10:07:48 +0000 (11:07 +0100)]
REQUIREMENTS: Add pointers to software packages.
Andre Noll [Fri, 23 Nov 2007 09:42:09 +0000 (10:42 +0100)]
net.c: Return proper error value in recv_bin_buffer().
Andre Noll [Fri, 23 Nov 2007 09:40:16 +0000 (10:40 +0100)]
In handle_connect() we really need a blocking fd for the client.
At least on NetBSD the fd returned by accept() might be in non-blocking
mode. So introduce mark_fd_blocking() and use it in handle_connect().
Andre Noll [Fri, 23 Nov 2007 09:35:19 +0000 (10:35 +0100)]
Replace shebang in bash scripts.
NetBSD does not have /bin/bash.
Andre Noll [Fri, 23 Nov 2007 09:33:41 +0000 (10:33 +0100)]
afs.c: Simplify activate_mood_or_playlist().
This also gets rid of
warning: `mode' might be used uninitialized in this function
on gcc-3.3.3.
Andre Noll [Fri, 23 Nov 2007 09:32:00 +0000 (10:32 +0100)]
Add wrapper for isspace().
This avoids
warning: subscript has type `char'
on netbsd.
Andre Noll [Wed, 21 Nov 2007 22:53:31 +0000 (23:53 +0100)]
gitweb.css: Improve readability.
Andre Noll [Wed, 21 Nov 2007 16:22:31 +0000 (17:22 +0100)]
Add some gitweb-releated stuff.
Andre Noll [Tue, 20 Nov 2007 22:13:48 +0000 (23:13 +0100)]
overview.sk: Minor improvements.
Andre Noll [Tue, 20 Nov 2007 21:54:00 +0000 (22:54 +0100)]
Remove another link to the live-demo.
Andre Noll [Tue, 20 Nov 2007 21:52:45 +0000 (22:52 +0100)]
Kill live-demo web page.
Andre Noll [Tue, 20 Nov 2007 20:58:05 +0000 (21:58 +0100)]
Add final 0.2.17 stuff.
Andre Noll [Tue, 20 Nov 2007 17:36:55 +0000 (18:36 +0100)]
the paraslash-0.2.17 release tarball
Andre Noll [Tue, 20 Nov 2007 17:13:01 +0000 (18:13 +0100)]
Fix html header.
The location of the cgi-bin dir on systemlinux is different from
paraslash.org. This broke the gitweb link in the left menu.
Andre Noll [Tue, 20 Nov 2007 19:08:08 +0000 (20:08 +0100)]
download.in.html: Replace paraslash.org in clone command.
Andre Noll [Mon, 19 Nov 2007 09:08:58 +0000 (10:08 +0100)]
Merge commit 'remotes/meins/v0.3' into v0.3
Andre Noll [Mon, 19 Nov 2007 09:08:46 +0000 (10:08 +0100)]
Announce NetBSD Port.
Andre Noll [Sun, 18 Nov 2007 23:33:31 +0000 (00:33 +0100)]
aft.c: Simplify print_list_item().
Andre Noll [Sun, 18 Nov 2007 23:32:59 +0000 (00:32 +0100)]
aft.c: Do not print directory if LS_FLAG_FULL_PATH was not given.
Andre Noll [Sun, 18 Nov 2007 21:19:36 +0000 (22:19 +0100)]
aft.c ls -lm: Fix unmapping of lyrics file.
Andre Noll [Sun, 18 Nov 2007 19:59:49 +0000 (20:59 +0100)]
Fix handling of invalid entries in the score table.
It may happen that the score table contains references to files that
no longer exist in the file system. The current code fails badly in
this case.
In open_next_audio_file(), if the file corresponding to the next
entry in the score table can not be opened, delete this entry from
the score table and try the next entry.
If the score table becomes empty, send NO_ADMISSIBLE_FILES back to para_server
and make recv_afs_result() switch to stop mode in this case.
Andre Noll [Sun, 18 Nov 2007 19:49:56 +0000 (20:49 +0100)]
Add additional sanity checks to osl_get_rank().
Check whether the riven rank is greater than zero and not greater than
the number of rows in the table.
Andre Noll [Sun, 18 Nov 2007 19:47:59 +0000 (20:47 +0100)]
Fix osl_del_row().
Only free volatile columns of the deleted row if OSL_DONT_FREE
is not set.
Andre Noll [Sat, 17 Nov 2007 19:35:23 +0000 (20:35 +0100)]
open_and_update_audio_file(): Interchange two arguments.
And add documentation of the "score" parameter.
Andre Noll [Sat, 17 Nov 2007 19:33:20 +0000 (20:33 +0100)]
REQUIREMENTS: Kill an incomplete sentence, add git.
Andre Noll [Sat, 17 Nov 2007 17:15:11 +0000 (18:15 +0100)]
Introduce vss_stopped().
Andre Noll [Sat, 17 Nov 2007 17:14:46 +0000 (18:14 +0100)]
Fix com_pause().
If the vss status is stopped, we must not switch to pause status.
Andre Noll [Sat, 17 Nov 2007 17:13:55 +0000 (18:13 +0100)]
fade.c: Fix client_cmd()
We have to wait for children to terminate because otherwise the
client commands may be executed in random order.
Since no caller checked the return value of client_cmd(), make it
abort on errors and change the return value to void.
Also, each caller only passed one string, so make it take only a
char * pointer.
Andre Noll [Sat, 17 Nov 2007 17:09:52 +0000 (18:09 +0100)]
stat.c: Cosmetics.
Andre Noll [Tue, 13 Nov 2007 19:10:48 +0000 (20:10 +0100)]
make_empty_status_items(): Add spaces after status item identifiers.
Identifiers without spaces confuse para_gui.
Andre Noll [Tue, 13 Nov 2007 19:08:06 +0000 (20:08 +0100)]
Fix tv_divide().
The old code contained an integer overflow which caused the mp3 audio
format handler to compute the chunk of large mp3 files incorrectly.
Moreover, the code was more complicated than necessary. So replace it
by a simple calculation which just transforms the given struct timeval
into its number of microseconds, does the division and transforms
the quotient back to a struct timeval.
Thanks to Gerrit Renker for pointing out the problem.
Andre Noll [Sun, 11 Nov 2007 19:24:20 +0000 (20:24 +0100)]
Fix com_nomore.
Andre Noll [Sun, 11 Nov 2007 19:23:45 +0000 (20:23 +0100)]
Avoid some gcc warnings.
Andre Noll [Sun, 11 Nov 2007 19:22:56 +0000 (20:22 +0100)]
Avoid empty lines in the status output.
Andre Noll [Sun, 11 Nov 2007 19:22:18 +0000 (20:22 +0100)]
Introduce make_empty_status_items().
At the end of the stream we have to reset the status items
because audiod would start a new receiver otherwise.
Andre Noll [Sun, 11 Nov 2007 13:58:28 +0000 (14:58 +0100)]
Add more status items.
Andre Noll [Sat, 10 Nov 2007 16:33:06 +0000 (17:33 +0100)]
Use FOR_EACH_STATUS_ITEM everywhere.
Andre Noll [Sat, 10 Nov 2007 16:23:04 +0000 (17:23 +0100)]
handle status items via autoconf.
Andre Noll [Sat, 3 Nov 2007 21:04:04 +0000 (22:04 +0100)]
Store chunk info in the afhi column rather than in the chunk column.
As the afhi column is mmapped, the chunk info is now available to
the ls command. The disk-storage column "chunks" only contains the
chunk table which allows to get rid of load_chunk_info() and
save_chunk_info().
Andre Noll [Sat, 3 Nov 2007 21:00:16 +0000 (22:00 +0100)]
aft.c: Fix a possible memory leak.
Andre Noll [Sat, 3 Nov 2007 20:58:55 +0000 (21:58 +0100)]
README, INSTALL: Small improvements.
Andre Noll [Fri, 2 Nov 2007 14:55:24 +0000 (15:55 +0100)]
More status item renames.
SI_LENGTH_MIN -> SI_BITRATE
SI_LENGTH_SEC -> SI_FREQUENCY
SI_ATTRIBUTES -> SI_ATTRIBUTES_BITMAP
SI_UPTIME -> SI_ATTRIBUTES_TXT
Andre Noll [Fri, 2 Nov 2007 14:52:03 +0000 (15:52 +0100)]
Don't report server uptime as status item.
This belongs to the server info.
Andre Noll [Fri, 2 Nov 2007 02:00:35 +0000 (03:00 +0100)]
Rename audio_info status items and get rid of duplicate afh info.
SI_AUDIO_INFO1 -> SI_AUDIO_FILE_INFO
SI_AUDIO_INFO2 -> SI_TAG_INFO1
SI_AUDIO_INFO3 -> SI_TAG_INFO2
The mp3 and the ogg afh stored bits of information in the info
string. Only store there what is not already contained in afh_info.
Andre Noll [Fri, 2 Nov 2007 01:48:15 +0000 (02:48 +0100)]
Interchange two lines in load_afhi().
Just to keep the oder consistent with safe_afhi().
Andre Noll [Fri, 2 Nov 2007 01:46:35 +0000 (02:46 +0100)]
Make the status item list globally visible.
Andre Noll [Fri, 2 Nov 2007 00:01:13 +0000 (01:01 +0100)]
audiod.c: Add missing space.
Andre Noll [Fri, 2 Nov 2007 00:00:42 +0000 (01:00 +0100)]
score.c: Use the new OSL_DONT_FREE flag for the aft column.
The score tables stores in one of its columns a pointer to
a row in the audio file table. This means for each admissible
file we're allocating space for a void* pointer to store the
aft pointer.
It's simpler and probably faster to store the afs pointer directly,
but of course that pointer must not be freed by the osl.
Andre Noll [Thu, 1 Nov 2007 23:52:48 +0000 (00:52 +0100)]
osl: Introduce volatile columns that need not be freed.
If the new OSL_DONT_FREE flag is given, osl_close_table()
will not try to free such objects.
Andre Noll [Thu, 1 Nov 2007 23:49:03 +0000 (00:49 +0100)]
Fix duplicate afs event add.
This bug hits if a request to update an existing audio file
is made. The old code caused an AFHI_CHANGE event and then
did "goto out;" which raises nother event (AUDIO_FILE_ADD).
Fix it by moving the event-raising code some lines up.
Andre Noll [Thu, 1 Nov 2007 20:50:18 +0000 (21:50 +0100)]
Always print a space after each status item identifier.
Andre Noll [Thu, 1 Nov 2007 20:32:34 +0000 (21:32 +0100)]
Get rid of afd->afsi and rename afs_status_info to verbose_ls_output.
Andre Noll [Thu, 1 Nov 2007 20:04:18 +0000 (21:04 +0100)]
Kill afd->current_play_mode.
It's unused.
Andre Noll [Thu, 1 Nov 2007 20:02:21 +0000 (21:02 +0100)]
kill afd->score.
This is also contained in afd->afs_status_info.
Andre Noll [Thu, 1 Nov 2007 19:45:34 +0000 (20:45 +0100)]
Get rid of afd->path.
All that info is contained in afd->afs_status_info.
Andre Noll [Thu, 1 Nov 2007 18:58:12 +0000 (19:58 +0100)]
Rename length status item to seconds_total and print it only once.
Andre Noll [Thu, 1 Nov 2007 18:20:40 +0000 (19:20 +0100)]
Fix number of whitespaces in duration status item.
Andre Noll [Thu, 1 Nov 2007 18:06:39 +0000 (19:06 +0100)]
Always write image_name and lyrics_name status output.
If there is no image_name, print "(none)". Same with
lyrics.
Andre Noll [Thu, 1 Nov 2007 18:03:14 +0000 (19:03 +0100)]
Split lyrics and image lines in stat output.
It's better to have the id and the name of the corresponding
blob as two different status items.
Andre Noll [Thu, 1 Nov 2007 17:49:39 +0000 (18:49 +0100)]
Kill duplicate audio format handler info string in stat output.
Andre Noll [Thu, 1 Nov 2007 17:43:07 +0000 (18:43 +0100)]
Kill duplicate num_played status item.
In fact, the two num_played values were different: The first
was the number of audio files streamed by para_server so far,
and the second one was the num_played value from struct afs_info.
The former is also contained in the output of com_si, so get
rid of it in the stat output.
Andre Noll [Thu, 1 Nov 2007 17:36:32 +0000 (18:36 +0100)]
Kill more duplicate status items.
Image ID and Lyrics ID are also contained in the ls -v output.
Andre Noll [Thu, 1 Nov 2007 17:31:59 +0000 (18:31 +0100)]
Kill duplicate audio format status item.
Andre Noll [Thu, 1 Nov 2007 17:23:05 +0000 (18:23 +0100)]
Kill unused afd.attributes_string.
Andre Noll [Thu, 1 Nov 2007 17:22:20 +0000 (18:22 +0100)]
Fix an off-by-one bug.
Andre Noll [Thu, 1 Nov 2007 17:06:49 +0000 (18:06 +0100)]
Don't compute attributes string twice.
Andre Noll [Thu, 1 Nov 2007 17:04:34 +0000 (18:04 +0100)]
Don't print attributes string twice.
Andre Noll [Thu, 1 Nov 2007 16:40:43 +0000 (17:40 +0100)]
Append ls -v output to status items.
This needs more work, but it avoids code duplication in the
long run.
Andre Noll [Thu, 1 Nov 2007 15:14:32 +0000 (16:14 +0100)]
README: Kill "obligatory" and "optional" tags.
All para_* executables are optional: The server-side programs
are not needed on a client and vice versa.
Andre Noll [Thu, 1 Nov 2007 15:11:33 +0000 (16:11 +0100)]
Makefile.in: web_sync is a directory.
Use rm -rf to get rid of it.
Andre Noll [Thu, 1 Nov 2007 14:55:30 +0000 (15:55 +0100)]
com_add: Only send output if send_callback_request() returned positive.
Andre Noll [Thu, 1 Nov 2007 14:53:46 +0000 (15:53 +0100)]
Add missing newline in ls output.
Andre Noll [Thu, 1 Nov 2007 14:51:25 +0000 (15:51 +0100)]
Interchange tcp ports of new and old para_server.
Andre Noll [Wed, 31 Oct 2007 14:22:24 +0000 (15:22 +0100)]
Increase default wake time from 8 to 9 hours.
Andre Noll [Wed, 31 Oct 2007 14:21:27 +0000 (15:21 +0100)]
Also save the header length and offset in the aft.
Andre Noll [Wed, 31 Oct 2007 14:18:55 +0000 (15:18 +0100)]
Fix ogg streaming.
Don't set the header len to zero in recv_afs_result().
Andre Noll [Wed, 31 Oct 2007 02:41:14 +0000 (03:41 +0100)]
vss.c: Check status afs socket fd for writing more often.
Also check it if the socket status is AFS_SOCKET_CHECK_FOR_WRITE.
Andre Noll [Wed, 31 Oct 2007 00:23:27 +0000 (01:23 +0100)]
doxgen: Kill double /ref.
Andre Noll [Wed, 31 Oct 2007 00:19:26 +0000 (01:19 +0100)]
More documentation.
Andre Noll [Wed, 31 Oct 2007 00:17:47 +0000 (01:17 +0100)]
command.c: Fix get_cmd_pointer.
The old code did not set the handler for afs commands at all. Bad.