]>
git.tue.mpg.de Git - adu.git/log
Andre Noll [Sat, 8 Nov 2008 22:54:16 +0000 (23:54 +0100)]
Fix a couple of gengetopt-related memory leaks.
It's still a bit leaky..
Andre Noll [Sat, 8 Nov 2008 22:05:54 +0000 (23:05 +0100)]
User handling improvments.
- move global variable num_uids to user.c.
- logging improvements.
- replace search_uid() by create_user_table(). search_uid() had a
horrible interface.
- in user.c, use FOR_EACH_USER() to loop over all users rather than
for_each_admissible_user().
Andre Noll [Sat, 8 Nov 2008 17:58:01 +0000 (18:58 +0100)]
Simplify user table closing.
No need for an extra function for freeing the hash table.
Andre Noll [Sat, 8 Nov 2008 17:26:24 +0000 (18:26 +0100)]
select.c: Fix two return values.
ERRNO_TO_ERROR() takes a _positive_ error code.
Andre Noll [Sat, 8 Nov 2008 17:21:13 +0000 (18:21 +0100)]
Output improvements.
- Implement appending to an output file.
- Do not override the output file by default
- Implement piping the output into a command.
Andre Noll [Fri, 7 Nov 2008 09:31:50 +0000 (10:31 +0100)]
Merge commit 'meins/master'
Andre Noll [Fri, 7 Nov 2008 09:31:20 +0000 (10:31 +0100)]
Rename error message for E_OUTPUT.
We might as well get this error without using an output file.
Andre Noll [Thu, 6 Nov 2008 23:09:50 +0000 (00:09 +0100)]
Add new select option to specify users by name.
This patch renames the short option -u for --uid to -U and introduces
the new --user option (short: -u) to specify admissible users by name.
The new option may be given mutltiple times to allow more than one user.
Andre Noll [Thu, 6 Nov 2008 22:15:21 +0000 (23:15 +0100)]
Move user and user ID related functions to separate files.
Andre Noll [Thu, 6 Nov 2008 20:16:30 +0000 (21:16 +0100)]
Move code for setting up the format string to an own function.
Andre Noll [Wed, 5 Nov 2008 17:30:28 +0000 (18:30 +0100)]
Fix return codes for loop functions.
The four different loop functions must set the return value in
their private struct because these functions are called from
within the osl library which will replace any negative return value
by -E_OSL_LOOP.
Andre Noll [Sun, 2 Nov 2008 21:41:12 +0000 (22:41 +0100)]
adu-0.0.4.
Andre Noll [Sun, 2 Nov 2008 21:39:22 +0000 (22:39 +0100)]
Add the latex and html directories to .gitignore.
These are created by doxygen.
Andre Noll [Sun, 2 Nov 2008 21:38:31 +0000 (22:38 +0100)]
Add more source code documentation.
Andre Noll [Sun, 2 Nov 2008 19:56:33 +0000 (20:56 +0100)]
Add more derived files to .gitignore.
Andre Noll [Sun, 2 Nov 2008 19:53:38 +0000 (20:53 +0100)]
make clean: Remove more derived files.
Andre Noll [Sun, 2 Nov 2008 19:53:24 +0000 (20:53 +0100)]
Add targets %.ppm and %.png.
Andre Noll [Sun, 2 Nov 2008 19:48:17 +0000 (20:48 +0100)]
Add man page, README, INSTALL, generate index.html.
Change the layout of the help text so that both the man page and
the index.html look nice.
Andre Noll [Sun, 2 Nov 2008 15:54:59 +0000 (16:54 +0100)]
Fix quoting of \n and \t in detailed select help.
Andre Noll [Sun, 2 Nov 2008 15:45:34 +0000 (16:45 +0100)]
Allow comments in interactive input.
This allows to put comments into adu scripts.
Andre Noll [Sun, 2 Nov 2008 15:41:31 +0000 (16:41 +0100)]
Fix interactive reset command.
We have to invalidate both the format info and the array of
admissible urls.
Andre Noll [Sat, 1 Nov 2008 23:35:29 +0000 (00:35 +0100)]
Make sure we never use a stale format info pointer in interactive mode.
Andre Noll [Sat, 1 Nov 2008 23:33:33 +0000 (00:33 +0100)]
parse_format_string(): Explicitly set the result pointer to NULL on errors.
Andre Noll [Sat, 1 Nov 2008 23:31:38 +0000 (00:31 +0100)]
format_items(): Check for NULL pointers.
And return NULL in this case, just as for an empty item list.
Andre Noll [Sat, 1 Nov 2008 22:56:46 +0000 (23:56 +0100)]
Fix a memory lead in interactive mode.
Andre Noll [Sat, 1 Nov 2008 22:47:03 +0000 (23:47 +0100)]
Init the format info struct in interactive mode.
Another bug which causes adu to segfault if used in interactive mode
and without setting any options.
Andre Noll [Sat, 1 Nov 2008 22:45:47 +0000 (23:45 +0100)]
Improve interactive feeling, kill dump command.
It's no good to spam the user with syntax errors on empty lines.
In popular shells, the set command prints the current environment
if called without arguments. So do the same and kill the dump command.
Andre Noll [Sat, 1 Nov 2008 21:57:15 +0000 (22:57 +0100)]
parse_select_options(): Check directly for NULL strings.
This is equivalent to checking whether a select option was given
in select mode, but it makes a difference in interactive mode.
Andre Noll [Sat, 1 Nov 2008 21:55:38 +0000 (22:55 +0100)]
Make free_format_info() cope with NULL pointers.
Be liberal with what you take, just as the usual free() function.
Andre Noll [Sat, 1 Nov 2008 21:42:33 +0000 (22:42 +0100)]
print_statistics(): Fix return value.
gengeopt should protect us from ever executing this code path,
but anyway.
Andre Noll [Sat, 1 Nov 2008 21:41:01 +0000 (22:41 +0100)]
parse_select_options(): Add missing break statements.
Doooh. This bug caused that we always used the user_summary_atoms.
Andre Noll [Sat, 1 Nov 2008 21:18:58 +0000 (22:18 +0100)]
Fix a bug in exec_interactive_command().
In case a command iwthout further options was given, p pointed one
byte after the malloced string, and this pointer is passed to the
command handler..
Andre Noll [Sat, 1 Nov 2008 21:07:23 +0000 (22:07 +0100)]
Minor documentation improvments.
Andre Noll [Sat, 1 Nov 2008 21:06:16 +0000 (22:06 +0100)]
Make it easier to print the help for select options.
It was always a bit awkward to print the help for the select options
because one had to specify a valid mode (-C -S or -I) and the required
-d option just to make gengetopt not bail out early.
Fix this flaw by not using gengetopt's internal help.
Andre Noll [Sat, 1 Nov 2008 19:22:09 +0000 (20:22 +0100)]
Fix parse_uid_arg().
The old code could segfault if an invalid --user argument was given.
Andre Noll [Sat, 1 Nov 2008 19:21:18 +0000 (20:21 +0100)]
Add format string doku, simplify format string handling.
As adu now only prints one list/summary at a time, there's only need
for one format string. So replace the four format-string related
option by a single --format option and add a detailed description
on how adu format strings may be used.
This further simplifies the select code a bit.
Andre Noll [Sat, 1 Nov 2008 17:02:07 +0000 (18:02 +0100)]
Make the array of summary comparators local.
Andre Noll [Sat, 1 Nov 2008 16:55:22 +0000 (17:55 +0100)]
Convert the user-lists to pretty-formating.
This allows to get rid of the old formating code and makes a couple
of select options unnecessary. Remove them.
Andre Noll [Sat, 1 Nov 2008 15:21:30 +0000 (16:21 +0100)]
Fix the user summary.
This broke recently.
Also, rename --sort to --list-sort because there's also the
--user-summary-sort option.
Andre Noll [Sat, 1 Nov 2008 14:26:57 +0000 (15:26 +0100)]
Fix the global summary.
This broke by the previous patch.
Andre Noll [Sat, 1 Nov 2008 13:30:28 +0000 (14:30 +0100)]
Introduce select-mode and use pretty formating for the global lists.
This patch introduces the new --select-mode option which is used
to specify which of the four possible output formats should be used.
Only this table is being printed.
The other change to select.c is that the global list also uses the
functions from format.c to pretty-print the output. The new
--global-list-format option may be used to customize the output.
Andre Noll [Tue, 28 Oct 2008 07:01:25 +0000 (08:01 +0100)]
adu.c: Add a comment describing the user table.
Andre Noll [Sun, 26 Oct 2008 21:30:34 +0000 (22:30 +0100)]
Makefile: Remove also the gengetop source files on make clean.
Andre Noll [Sun, 26 Oct 2008 15:41:36 +0000 (16:41 +0100)]
Remove unused --format select option.
Andre Noll [Sun, 26 Oct 2008 15:06:03 +0000 (16:06 +0100)]
Introduce --global-summary-format.
This allows to pretty-format also the global summary. This patch also
closes some memory leaks.
Andre Noll [Sun, 26 Oct 2008 13:19:27 +0000 (14:19 +0100)]
Use the new formating code to print the user summary.
We don't need gengetopt's string parser any more, so don't create the
code for it.
Andre Noll [Sun, 26 Oct 2008 13:13:01 +0000 (14:13 +0100)]
Add create_argv() to string.c.
A problem with gengetopt's string parser is that it can not handle
whitespace within parameters. It's therefore necessary to roll our
own line splitting code.
Andre Noll [Sat, 18 Oct 2008 21:23:46 +0000 (23:23 +0200)]
Make parse_format_string() return int.
It's much cleaner to let public functions return a negative
error code on failure.
Andre Noll [Sat, 18 Oct 2008 18:50:06 +0000 (20:50 +0200)]
Merge commit 'fml/master'
Andre Noll [Sat, 18 Oct 2008 15:20:58 +0000 (17:20 +0200)]
Add pretty-printing formating functions.
This adds a generic format string parser. The new code is compiled
in but not yet used.
Andre Noll [Sun, 12 Oct 2008 22:58:10 +0000 (00:58 +0200)]
Merge commit 'fml/master'
Andre Noll [Wed, 2 Jul 2008 16:19:07 +0000 (18:19 +0200)]
Handle select help options properly.
The old code never printed out the help texts.
Andre Noll [Tue, 1 Jul 2008 19:26:26 +0000 (21:26 +0200)]
Merge commit 'fml/master'
Conflicts:
Makefile
Andre Noll [Mon, 30 Jun 2008 15:53:52 +0000 (17:53 +0200)]
Implement --output.
The option was added long ago, but the implementation was missing..
Andre Noll [Mon, 23 Jun 2008 16:15:07 +0000 (18:15 +0200)]
adu-0.0.3.
Andre Noll [Mon, 23 Jun 2008 13:59:14 +0000 (15:59 +0200)]
Implement the interactive "run" command to run the select query.
This was a straight-forward task, given the preparations of the
past few patches.
Andre Noll [Mon, 23 Jun 2008 12:47:22 +0000 (14:47 +0200)]
Introduce run_select_query().
This is just the part of com_select() that will be called from
the run command of interactive.c.
Andre Noll [Mon, 23 Jun 2008 11:58:38 +0000 (13:58 +0200)]
Make struct admissible uids local.
It is only used in read_uid_file. So pass it as an arg to this
function.
Andre Noll [Mon, 23 Jun 2008 11:53:57 +0000 (13:53 +0200)]
Use only one copy of struct select_conf.
Previously, we had one copy in select.c and another copy in
interactive.c. Define a single copy in adu.c instead and use
it from both interactive.c and select.c.
Andre Noll [Mon, 23 Jun 2008 11:48:54 +0000 (13:48 +0200)]
com_select(): Minor cleanup.
Move params struct into the if clause where it is used.
Andre Noll [Fri, 20 Jun 2008 15:30:26 +0000 (17:30 +0200)]
Move remaining select options from adu.ggo to select.ggo.
Andre Noll [Fri, 20 Jun 2008 15:23:20 +0000 (17:23 +0200)]
Move --no-user-summary to select.ggo.
Andre Noll [Fri, 20 Jun 2008 15:21:10 +0000 (17:21 +0200)]
Move --user-summary-sort to select.ggo.
Andre Noll [Fri, 20 Jun 2008 15:18:13 +0000 (17:18 +0200)]
Move --size-unit and --count-unit from adu.ggo to select.ggo.
Andre Noll [Fri, 20 Jun 2008 13:37:02 +0000 (15:37 +0200)]
Remove the --limit option from adu.ggo.
Use --limit from select.ggo instead.
Andre Noll [Fri, 20 Jun 2008 13:27:02 +0000 (15:27 +0200)]
Make --uid take a comma-separated list of uids and move it to select.ggo.
This means --uid no needs to be a multiple option.
Also, add descriptions to all interactive commands.
Andre Noll [Fri, 20 Jun 2008 13:23:14 +0000 (15:23 +0200)]
Re-activate -Wuninitialized.
Andre Noll [Fri, 20 Jun 2008 08:44:54 +0000 (10:44 +0200)]
Fix prototype of com_create().
Andre Noll [Fri, 20 Jun 2008 08:44:40 +0000 (10:44 +0200)]
Kill two unused variables.
Andre Noll [Fri, 20 Jun 2008 08:44:16 +0000 (10:44 +0200)]
Move the uid-range parser to string.c.
This code will also be needed by the interactive mode.
Andre Noll [Fri, 20 Jun 2008 08:40:13 +0000 (10:40 +0200)]
Add rudimentary interactive support.
This needs much more work..
Andre Noll [Thu, 19 Jun 2008 13:45:11 +0000 (15:45 +0200)]
Fix typo in Makefile.
Andre Noll [Wed, 18 Jun 2008 18:47:13 +0000 (20:47 +0200)]
Fix typo in Makefile.
Andre Noll [Wed, 18 Jun 2008 18:28:06 +0000 (20:28 +0200)]
Merge commit 'fml/master'
Andre Noll [Wed, 18 Jun 2008 13:18:06 +0000 (15:18 +0200)]
Add large file support.
This is needed on 32bit systems for files > 2G. Only tested on Linux
so far.
Andre Noll [Wed, 18 Jun 2008 12:45:57 +0000 (14:45 +0200)]
Replace value of PRIME1.
It wasn't a prime at all ;)
Andre Noll [Thu, 5 Jun 2008 20:29:59 +0000 (22:29 +0200)]
Merge commit 'fml/master'
Andre Noll [Thu, 5 Jun 2008 16:58:38 +0000 (18:58 +0200)]
Fix and simplify get_dir_name_by_number() and friends.
That was quite buggy. Fortunately, this fixed version is even
simpler than the buggy code we've had before.
Andre Noll [Thu, 5 Jun 2008 16:56:58 +0000 (18:56 +0200)]
scan_dir(): Print error reason if lstat() failed.
Andre Noll [Wed, 4 Jun 2008 19:08:22 +0000 (21:08 +0200)]
Merge commit 'fml/master'
Andre Noll [Tue, 3 Jun 2008 15:52:08 +0000 (17:52 +0200)]
Add the --print-base-dir option.
Andre Noll [Mon, 2 Jun 2008 17:57:35 +0000 (19:57 +0200)]
Add the funny adu logo.
Andre Noll [Mon, 2 Jun 2008 08:20:56 +0000 (10:20 +0200)]
adu-0.0.2
Andre Noll [Sun, 1 Jun 2008 22:55:36 +0000 (00:55 +0200)]
Add options for selecting what to print.
Andre Noll [Sun, 1 Jun 2008 21:29:59 +0000 (23:29 +0200)]
Rename size_unit to size-unit and count_unit to count-unit.
Other multi-word options also use a hyphen rather than an underscore.
Andre Noll [Sun, 1 Jun 2008 21:22:04 +0000 (23:22 +0200)]
Header cleanup.
No need to include lots of network-related header files.
Andre Noll [Sun, 1 Jun 2008 21:21:13 +0000 (23:21 +0200)]
Make user summary sortable by user defined column.
This adds the user-summary-sort option
Andre Noll [Sun, 1 Jun 2008 18:29:16 +0000 (20:29 +0200)]
Get rid of global variables num_dirs, num_files, and num_bytes.
These were defined in adu.c but not used there at all.
In fact, create.c only used num_dirs in scan_dir() as a counter for
the directory currently being processed while the other two were not
really used at all. Make num_dirs local to scan_dir(), rename it to
current_dir_num and remove the other two.
The only "real" users of these variables are all in select.c, so move
them there and make them static.
Andre Noll [Sun, 1 Jun 2008 18:08:32 +0000 (20:08 +0200)]
Move ui_used() and ui_admissible() from adu.h to adu.c.
They are only used there.
Andre Noll [Sun, 1 Jun 2008 17:53:55 +0000 (19:53 +0200)]
Add .gitignore.
Hopefully this makes it less likely to forget to check in important
files.
Andre Noll [Sun, 1 Jun 2008 17:52:17 +0000 (19:52 +0200)]
Add create.c.
Oops, forgot to check it in..
Andre Noll [Sun, 1 Jun 2008 17:50:16 +0000 (19:50 +0200)]
Hide the implementation of the uid hash table.
The commands should not know anything about the details.
So replace the FOR_EACH_USER macro by for_each_admissible_user()
which takes a function pointer and calls the given function for
each admissible user, passing a pointer to the user_info struct
of that user.
This allows to un-export uid_hash_table_size and uid_hash_table.
Andre Noll [Sun, 1 Jun 2008 17:08:51 +0000 (19:08 +0200)]
Implement --hash-table-bits.
Andre Noll [Sun, 1 Jun 2008 16:43:39 +0000 (18:43 +0200)]
Also catch SIGPIPE.
Otherwise, "adu -S | invalid_command" kills the adu process and
we're left with dirty osl tables.
Andre Noll [Sun, 1 Jun 2008 16:33:18 +0000 (18:33 +0200)]
Let gengetopt check the given args.
Andre Noll [Sun, 1 Jun 2008 16:32:49 +0000 (18:32 +0200)]
--base-dir must not be a required option.
Otherwise, gengetopt would complain if it is not given even in
--select mode. Make it optional and check manually whether it
is given in --create mode.
Andre Noll [Sun, 1 Jun 2008 16:31:05 +0000 (18:31 +0200)]
Check args before initializing signal handlers.
Andre Noll [Sun, 1 Jun 2008 16:16:58 +0000 (18:16 +0200)]
Move the code for the create command to its own file.
Andre Noll [Sun, 1 Jun 2008 15:50:41 +0000 (17:50 +0200)]
Move the code for the select command to its own file.
Andre Noll [Sun, 1 Jun 2008 14:51:10 +0000 (16:51 +0200)]
Fix a typo in documentation.