From 0afd787fee5d6990c6a0fa91767ab1c4322f8908 Mon Sep 17 00:00:00 2001 From: Andre Noll Date: Tue, 1 Apr 2008 22:05:46 +0200 Subject: [PATCH] wng_open(): Defer registering the wng task. This way we do not have to unregister it on errors. --- write_common.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/write_common.c b/write_common.c index f9560d7f..037bb728 100644 --- a/write_common.c +++ b/write_common.c @@ -79,7 +79,6 @@ int wng_open(struct writer_node_group *g) int i, ret = 1; PARA_NOTICE_LOG("opening wng %p with %d writer(s)\n", g, g->num_writers); - register_task(&g->task); FOR_EACH_WRITER_NODE(i, g) { struct writer_node *wn = &g->writer_nodes[i]; wn->wng = g; @@ -90,10 +89,10 @@ int wng_open(struct writer_node_group *g) g->max_chunk_bytes = PARA_MAX(g->max_chunk_bytes, ret); } sprintf(g->task.status, "%s", "writer node group"); + register_task(&g->task); return 1; err_out: PARA_ERROR_LOG("%s\n", para_strerror(-ret)); - unregister_task(&g->task); while (i > 0) { struct writer_node *wn = &g->writer_nodes[--i]; wn->writer->close(wn); -- 2.39.5