From a62a0bb8fab75f42a3ae165d85e01fb0b98de056 Mon Sep 17 00:00:00 2001 From: Andre Noll Date: Thu, 7 Oct 2021 21:22:59 +0200 Subject: [PATCH] stdin/stdout: Streamline documentation of {pre,post}_select(). Don't state the obvious and avoid talking about fd sets. --- stdin.c | 9 ++++----- stdout.c | 6 +++--- 2 files changed, 7 insertions(+), 8 deletions(-) diff --git a/stdin.c b/stdin.c index 5f9259f7..607435d2 100644 --- a/stdin.c +++ b/stdin.c @@ -14,8 +14,8 @@ #include "string.h" /* - * If there is space left in the buffer of the stdin task add STDIN_FILENO to - * the read fd set of s. + * If there is space left in the buffer of the stdin task, ask the scheduler to + * monitor STDIN_FILENO. */ static void stdin_pre_select(struct sched *s, void *context) { @@ -33,9 +33,8 @@ static void stdin_pre_select(struct sched *s, void *context) } /* - * This function checks if STDIN_FILENO was included by in the read fd set of s - * during the previous pre_select call. If so, and if STDIN_FILENO is readable, - * data is read from stdin and fed into the buffer tree. + * Feed data from stdin into the buffer tree if STDIN_FILENO is ready for + * reading. */ static int stdin_post_select(__a_unused struct sched *s, void *context) { diff --git a/stdout.c b/stdout.c index 4af40984..f31b8675 100644 --- a/stdout.c +++ b/stdout.c @@ -10,7 +10,7 @@ #include "stdout.h" #include "buffer_tree.h" -/* Add STDOUT_FILENO to the write fd set if there is input data available. */ +/* Monitor STDOUT_FILENO if there is input data available. */ static void stdout_pre_select(struct sched *s, void *context) { struct stdout_task *sot = context; @@ -24,8 +24,8 @@ static void stdout_pre_select(struct sched *s, void *context) } /* - * This function writes input data from the buffer tree to stdout if - * STDOUT_FILENO is writable. + * If input from the buffer tree is available and STDOUT_FILENO is ready, write + * as much as possible. */ static int stdout_post_select(struct sched *s, void *context) { -- 2.39.5