DSS - dyadic snapshot scheduler https://git.tue.mpg.de/cgit/dss/atom?h=maint 2017-04-16T10:32:06Z 2017-04-16T10:32:06Z Andre Noll maan@tuebingen.mpg.de 2017-02-17T14:36:50Z urn:sha1:ae647da612e0edfb607a4fdb251983d6405f6b00 This function is rather big, so it's not clear whether it should be inlined or not. Without the inline attribute, that's up to the compiler to decide. 2017-04-16T10:32:06Z Andre Noll maan@tuebingen.mpg.de 2017-02-17T14:15:10Z urn:sha1:b795331d8f7006e1cd15ddf124baf1384347d2db The function only reads from the location pointed at by the config_file variable. 2017-04-16T10:32:06Z Andre Noll maan@tuebingen.mpg.de 2017-04-16T10:18:11Z urn:sha1:01af36ee3cd794f4332c4898828a31aafe0a939f In the error case do_semop() already returns the error code which corresponds to errno. 2016-08-21T19:13:25Z Andre Noll maan@tuebingen.mpg.de 2016-06-17T07:18:40Z urn:sha1:03918564cf43cfbd4f873f1b9c6ec3ccd15ede91 There is no need to actually obtain the lock. A single semaphore operation will do just fine. With sem_op equal to zero and IPC_NOWAIT the semop() call returns immediately, and the return value tells whether the semaphore value was zero. Rename the (static) function to mutex_is_locked() to indicate that it performs only read-only operations on the semaphore set. 2016-08-21T19:13:25Z Andre Noll maan@tuebingen.mpg.de 2016-06-16T21:06:29Z urn:sha1:81d9c8b0e49a12f7b726b06e2df48c2c3314bbcb This changes get_dss_pid() to handle the case where the caller passed a NULL pid pointer. Conversely, if pid is not NULL, we now make sure to initialize the given address in all cases. The single caller currently never passes NULL, so this change is just defensive programming, protecting against future users. Be liberal in what you accept, be strict in what you return.. 2012-09-16T11:34:07Z Andre Noll maan@systemlinux.org 2012-09-16T11:34:07Z urn:sha1:6c76799c7334a12926dc1cf0c32670423cbc954f Has been cooking for several weeks. The conflicts daemon.c exec.c file.c ipc.c sig.c are trivial and can be resolved easily. 2012-08-15T09:41:32Z Andre Noll maan@systemlinux.org 2012-08-11T18:32:19Z urn:sha1:46cbddf465bd66ba1d5c4bcc780ae0d65abd7f73 As pointed out by Daniel Richard G. some of the dss header files are named the same as system header files. This patch renames these headers as well as their corresponding .c files. Specifically, error.h, fd.h, signal.h, string.h and time.h become err.h, file.h, sig.h, str.h and tv.h. 2012-08-15T09:39:26Z Daniel Richard G skunk@iSKUNK.ORG 2012-08-10T12:41:22Z urn:sha1:66cdd5bc99a53d2b408a6cdc2d501fe27f9db13b Variadic macros were introduced in C99, so they are not supported on ANSI C compilers. Since currently all DSS_*_LOG macros are variadic, we need a replacement for these. Moreover, since not all compilers support __func__ or an equivalent, we need to check for this feature as well and provide a workaround if necessary. This patch introduces the new public function dss_log_set_params() which saves the given log level, filename, line number and the function name in global variables. The DSS_*_LOG macros are changed to receive a single argument only, which is the usual variadic list, enclosed in additional parentheses. The new DSS_*_LOG macros first set the log parameters by calling dss_log_set_params(), then call dss_log() with the variadic list as the argument. dss_log() is patched to print the function name only if __func__ is supported and fall back to file name and the line number otherwise. All DSS_*_LOG() calls are changed to the new syntax. 2012-08-15T09:39:26Z Daniel Richard G skunk@iSKUNK.ORG 2012-08-10T12:20:57Z urn:sha1:b3aca66350a1a4244cdad55fcd8cd64293336006 This replaces the C99-only initializations in mutex_lock() and mutex_try_lock() by equivalent but portable code. 2012-08-15T09:39:26Z Daniel Richard G skunk@iSKUNK.ORG 2012-08-10T12:16:22Z urn:sha1:c17bfe9242f34690bd26747144f5351011e91b41 This is both to ensure function signature consistency, and to eliminate GCC's "no previous declaration for _____" warnings.