paraslash/audiod.c, branch puparaslash - network audio streaming toolshttps://git.tue.mpg.de/cgit/paraslash/atom?h=pu2026-10-23T22:16:39ZMerge topic branch t/mixer into pu2026-10-23T22:16:39ZAndre Nollmaan@tuebingen.mpg.de2026-10-23T22:16:39Zurn:sha1:50cfa44d1542c34ac452068e947cac4df68ef203
para_mixer improvements
-----------------------
Link para_mixer with audioc_common.o to make it single threaded.
* t/mixer:
Make para_mixer single-threaded.
mixer: Introduce die().
crypt: use {con,de}structor to init/shutdown the library.
client: Use a named enumeration for the client status.
Introduce struct client_config to hide context from public API.
mixer: Link with audioc_common.o
Move recv_buffer() and recv_bin_buffer() from net.c to fd.c.
mixer: Rename client_cmd() -> run_client_cmd().
mixer: Rename audioc_cmd() -> run_audioc_cmd().
f2026-10-13T15:41:49ZAndre Nollmaan@tuebingen.mpg.de2026-10-13T15:41:49Zurn:sha1:8464173174201711151a156d3a4eceaba08aaa86audiod: Improve SI_decoder_flags handling.2026-10-13T15:36:34ZAndre Nollmaan@tuebingen.mpg.de2026-10-12T20:12:23Zurn:sha1:656ac9ca6cff796cf01bf56d4203d593235922ed
Rather than allocating and computing the string in each call to
dump_audiod_status_items(), only allocate it once and update it when the
slot is opened or closed.
audiod: Reduce time string update frequency.2026-10-13T15:36:34ZAndre Nollmaan@tuebingen.mpg.de2026-10-10T21:52:04Zurn:sha1:6179ff479b01bc9f7471b37dd5a764ce2d5b80f7
Use the sub-fraction part of the time string to set the new global
next_status_dump to when the "seconds" field is going to change.
audiod: Improve SI_audiod_status handling.2026-10-13T15:36:34ZAndre Nollmaan@tuebingen.mpg.de2026-10-12T17:46:09Zurn:sha1:feacb544943cf7e38e509ffa0eab01402328023c
Currently each invocation of dump_status_items() creates the new value of
this status item, compares it against the current value and notifies the
status clients if the value has changed. It is easier to update the status
item and notify the clients from the relevant command handlers instead.
audiod: Improve and rename close_stat_pipe().2026-10-13T15:36:34ZAndre Nollmaan@tuebingen.mpg.de2026-10-13T15:28:51Zurn:sha1:04f9c7dbf69493afb145e5b6a3755d5e7a4d71e9
Skip the four audiod status items, combine the two loops and use a less
confusing function name. After all, the fd for the connection refers to a
Unix domain socket, not a pipe.
audiod: Avoid unnecessary allocation/free.2026-10-12T20:43:10ZAndre Nollmaan@tuebingen.mpg.de2026-10-11T22:46:14Zurn:sha1:15c1fc1119ac1c5507895817f615fbc76ef5b457
The length of the decoder flags string is known at compile time. No need to
use malloc()/free() here.
Besides, the function can be static.
audiod: Only check for connections if socket is readable.2026-10-12T20:43:10ZAndre Nollmaan@tuebingen.mpg.de2026-10-11T22:19:11Zurn:sha1:05ac496f091d63f8e0991efc2fd775369c7330d5
This saves one system call per scheduler iteration in the common case where
no connection is pending.
audiod: Drop unnecessary call to clear_status_items().2026-10-12T20:43:10ZAndre Nollmaan@tuebingen.mpg.de2026-10-10T23:28:50Zurn:sha1:abe38b2274bc251456381cc6476cd9a2990c29ac
close_stat_pipe() already called this, so remove the superfluous call from
audiod_cleanup(). Now close_stat_pipe() is the only remaining caller of
clear_status_items(), so inline this function there.
audiod: Rename audiod_status_dump() -> dump_audiod_status_items().2026-10-12T20:43:03ZAndre Nollmaan@tuebingen.mpg.de2026-10-10T20:31:44Zurn:sha1:49c752006f460a589eabc41b2254c44b4d41b8bc