paraslash/bitstream.c, branch master

Include regex.h from para.h.

2025-05-19T17:35:58Z

Every .c file includes it anyway.

string: Introduce arr_realloc() and check for integer overflow.

2022-07-29T17:22:09Z

Use __builtin_mul_overflow() for the check. This builtin was introduced in gcc-5, so we need to bump the lowest supported version. Re-implement para_realloc() as a trivial wrapper for arr_realloc() to simplify and to avoid duplicating the size check.

Shorten copyright notice.

2017-09-22T14:35:22Z

The GPLv2 line does not add any additional information, so drop it. This leaves a single line of legalese text for most files, which is about the amount of screen real estate it deserves. This patch was created with the following script (plus some manual fixups): awk '{ if (NR <= 5) { gs = gensub(/.*Copyright.* ([0-9]+).*Andre Noll.*/, "\\1", "g") if (gs != $0) year = gs next } if (NR == 6 && year != "") printf("/* Copyright (C) %s Andre Noll , see file COPYING. */\n", year) print }'

wma: Simplify get_vlc().

2017-07-06T19:00:36Z

The "bits" argument of the function is implicitly given by the vlc structure and may thus be omitted from the call. For this to work we must pass a pointer to struct vlc instead of only the table, which further simplifies wmadec_filter.c.

wma: Remove pointless VLC_TYPE define.

2017-07-06T19:00:36Z

It was defined to int16_t which only obfuscates the code.

wmadec: Use read_u32_be().

2017-03-25T10:58:52Z

The shift operation in show_bits() was buggy because p[0] is promoted to int, and the shift p[0] << 24 results in undefined behavior, causing the sanitizer of gcc to complain: bitstream.h:40:21: runtime error: left shift of 230 by 24 places cannot be represented in type 'int' read_u32_be() gets this right.

wmadec: Simplify get_vlc().

2016-03-06T20:29:06Z

The last parameter is always bigger than 2, which is all the function needs to know. Hence we may remove the parameter and get rid of some macros that were only used to compute it.

bitstream.c: Convert GET_DATA macro to inline function.

2015-09-20T18:32:21Z

There is no benefit from defining this as a macro. With the inline function we get type safety for free, and the new version is better readable.

Remove unnecessary system header includes.

2015-01-12T22:28:28Z

All these headers get included from para.h.

bitstream: Improve documentation.

2014-04-22T00:26:43Z

Mention that the bitstream API is only used for the WMA decoder, avoid overlong descriptions of function parameters and add some doxygen \ref commands.