paraslash/bitstream.h, branch pu

Shorten copyright notice.

2017-09-22T14:35:22Z

The GPLv2 line does not add any additional information, so drop it. This leaves a single line of legalese text for most files, which is about the amount of screen real estate it deserves. This patch was created with the following script (plus some manual fixups): awk '{ if (NR <= 5) { gs = gensub(/.*Copyright.* ([0-9]+).*Andre Noll.*/, "\\1", "g") if (gs != $0) year = gs next } if (NR == 6 && year != "") printf("/* Copyright (C) %s Andre Noll , see file COPYING. */\n", year) print }'

wma: Simplify get_vlc().

2017-07-06T19:00:36Z

The "bits" argument of the function is implicitly given by the vlc structure and may thus be omitted from the call. For this to work we must pass a pointer to struct vlc instead of only the table, which further simplifies wmadec_filter.c.

wma: Remove pointless VLC_TYPE define.

2017-07-06T19:00:36Z

It was defined to int16_t which only obfuscates the code.

wma: Make bitstream API more robust.

2017-07-06T19:00:36Z

The ->buffer_end field of struct getbit_context is set but never used. In fact, we never check bounds and happily read beyond the supplied data buffer. Fix this by replacing the field by ->num_bits, an integer which is initialized in init_get_bits() to the number of bits available. All functions which read the bitstream are modified to check bounds.

wmadec: Use read_u32_be().

2017-03-25T10:58:52Z

The shift operation in show_bits() was buggy because p[0] is promoted to int, and the shift p[0] << 24 results in undefined behavior, causing the sanitizer of gcc to complain: bitstream.h:40:21: runtime error: left shift of 230 by 24 places cannot be represented in type 'int' read_u32_be() gets this right.

bitstream.h: Remove some superflous parentheses.

2016-03-06T20:29:06Z

wmadec: Simplify get_vlc().

2016-03-06T20:29:06Z

The last parameter is always bigger than 2, which is all the function needs to know. Hence we may remove the parameter and get rid of some macros that were only used to compute it.

bitstream: Improve documentation.

2014-04-22T00:26:43Z

Mention that the bitstream API is only used for the WMA decoder, avoid overlong descriptions of function parameters and add some doxygen \ref commands.

wma: Doxify some comments.

2012-06-16T12:49:02Z

struct coef_vlc_table->levels and struct getbit_context had undoxified comments.

Add documentation of struct vlc.

2009-12-20T15:23:56Z