paraslash/command.c, branch masterparaslash - network audio streaming toolshttps://git.tue.mpg.de/cgit/paraslash/atom?h=master2026-05-30T21:55:06ZMerge topic branch t/socket-cookie into master2026-05-30T21:55:06ZAndre Nollmaan@tuebingen.mpg.de2026-05-30T21:54:09Zurn:sha1:4c2b1f24524fb5003e6c766d8f3848d7c27cf6a4
AFS socket cookie replacement
-----------------------------
A small but rather intrusive patch set which touches the guts of the afs
callback mechanism.
* t/socket-cookie:
afs: Avoid the void * argument of send_lls_callback_request().
Kill afs socket cookie and afs_client_list.
afs: Improve error handling of afs_signal_post_monitor().
command.c: Move and improve comment for current_time.2026-05-26T11:48:43ZAndre Nollmaan@tuebingen.mpg.de2026-05-08T22:59:01Zurn:sha1:f181167423aabc3576ad7df615c1c9b386bdebe6
Move it next to the definition of the variable it purports to document,
and reword the comment to clarify why nobody updates the now pointer in
command handler context.
command.c: Remove unnecessary casts.2026-05-24T18:52:28ZAndre Nollmaan@tuebingen.mpg.de2026-05-08T23:03:13Zurn:sha1:a3b65222fb71dfbb3bfa0e0334f98e0c92ee7df3
The comment from commit f90e920b4 in 2017 no longer applies to more recent
clang versions. In particular clang version 19.1.7 of FreeBSD 13.5 does not
complain without the casts. so..
server: Move alarm(2) call into handle_connect() of command.c.2026-05-08T20:19:58ZAndre Nollmaan@tuebingen.mpg.de2026-04-01T22:52:19Zurn:sha1:03021ecdbdd7bfe840c503adb1891e7c1f0d6da2
Since the alarm clock is cancelled in handle_connect(), let's also set it
there. Remove the pointless ALARM_TIMEOUT macro while at it.
Prefer paraslash_version() over PACKAGE_VERSION.2026-05-03T19:15:30ZAndre Nollmaan@tuebingen.mpg.de2026-04-28T17:12:59Zurn:sha1:0fcf0ab6852d64d6b9941f850dbdcdcde1b60d1f
Currently we use at several places the package version, i.e. the version
that was checked out when the package was configured. The paraslash version
is recomputed every time the package is build, so this is more up-to-date.
So use paraslash_version() everywhere and remove PACKAGE_VERSION.
Kill afs socket cookie and afs_client_list.2026-04-29T18:37:48ZAndre Nollmaan@tuebingen.mpg.de2026-03-31T22:40:53Zurn:sha1:7557912e8a30577b85ae91c7f984173776e72e09
We now create a per-command socket pair in the command handler and use the
permanent server-afs socket to pass one end of the pair from the command
handler to the afs process.
With this approach only the command handlers can possibly talk to the
afs process, so we don't need to worry about malicious or bogus connections
arriving at the local socket.
Consequently, we may remove the socket cookie and employ blocking I/O for the
shared memory identifiers that are transferred through the per-command socket.
Connections are now dispatched in one go, obviating the need to keep track
of connected clients. So remove struct afs_client and the client list.
Switch to SPDX identifiers.2026-03-17T22:45:43ZAndre Nollmaan@tuebingen.mpg.de2026-03-15T14:57:29Zurn:sha1:ea0cecf96e08c489fdcc94d046019f4ce46f58e2
Generated with
sed -i 's|Copyright.*Andre Noll.*|SPDX-License-Identifier: GPL-2.0 */|g' *.c *.h
followed by manually tweaking the result a bit. No license change intended.
Move user_list.[ch] into server.[ch].2026-03-01T13:44:14ZAndre Nollmaan@tuebingen.mpg.de2026-02-13T20:28:13Zurn:sha1:81a135b2cfee5c3d54c30c8ffea601c7a24fbf6d
This works because only the server links with user_list.o. Since struct user
contains a list head, list.h must now be included *before* server.h, which
requires some trivial header shuffling in the .c files that include server.h.
aft.c: Boolify send_afs_status().2026-03-01T13:44:14ZAndre Nollmaan@tuebingen.mpg.de2026-02-16T21:00:16Zurn:sha1:8e3c1445477beb9d94aee5be28bce560998d6dfe
The "parser_friendly" parameter is used as a boolean, so don't declare it
as int. The function passes a reference to the bool via the callback method,
so the callback, afs_stat_callback(), needs to be adjusted as well.
Merge topic branch t/rm_dccp into master2026-02-18T13:38:44ZAndre Nollmaan@tuebingen.mpg.de2026-02-18T13:37:48Zurn:sha1:ad58e59cfcf195710d0b96a141e62074a81e948d
Remove dccp support
The first patch of this series removes the dccp sender and receiver. Both are
deprecated as of paraslash-0.7.6, released in 2025-11. The short depreciation
period should not be a problem because dccp was never adopted widely, and
the linux kernel no longer supports the protocol.
The removal paves the way for quite some subsequent cleanups. In particular,
the acl and chunk queue APIs, which used to be shared between the http and
the dccp sender, no longer need to be public, so subsequent patches of the
series move acl.c and chunk_queue.c into http_send.c.
* refs/heads/t/rm_dccp:
http_send.c: Simplify format_url().
Move format_url() from net.c to http_send.c.
Merge acl.c into http_send.c.
Merge chunk_queue.c into http_send.c.
http_send.c: Move header_sent to struct private_http_sender_data.
http_send.c: Move chunk queue into struct private_http_sender_data.
struct sender: Remove unused sched pointer argument of ->post_monitor().
struct sender: Remove unused chunks_sent parameter of ->send().
http_send.c: Kill http_send_ok_msg() and http_send_err_msg().
http_send.c: Remove trivial shutdown wrapper.
http_send.c: Merge free_sender_status() into http_shutdown().
http_send.c: Merge init_sender_status() into http_send_init().
http_send.c: Rename or remove generic_foo().
http_send.c: Remove sender_status pointer arguments.
Move struct sender_status into http_send.c.
Move send_common.c into http_send.c.
Remove dccp.