paraslash/exec.c, branch nextparaslash - network audio streaming toolshttps://git.tue.mpg.de/cgit/paraslash/atom?h=next2026-08-01T20:18:30Zexec: Rename para_exec_cmdline_pid() to xexec().2026-08-01T20:18:30ZAndre Nollmaan@tuebingen.mpg.de2026-07-22T17:43:18Zurn:sha1:542c4a5da15efc05342f99e092e6a2e2b831c126
This is shorter and conveys enough information. Rename the static para_exec()
as well.
exec: Detect and report exec errors.2026-07-26T21:54:39ZAndre Nollmaan@tuebingen.mpg.de2026-04-20T17:29:32Zurn:sha1:3f661d865d5a29ee37f7984d7689e1d91902cac3
In para_exec(), the parent does not detect errors that occur in the child
after the call to fork() succeeded. This includes the common error case
where the child's call to execvp() fails due to a path lookup error.
It is not difficult to implement error detection by introducing an additional
"control" pipe whose file descriptors are opened with O_CLOEXEC. If the
child's call to execvp() succeeds, the OS closes the descriptor and the
function does not return, Otherwise the descriptor remains open and execvp()
returns with errno set to indicate the error. In this case the child writes a
four byte representation of errno to the control pipe and exits. The parent
reads from the other end of the pipe. If the read returns zero, execvp()
succeeded. Otherwise, the parent has an error code to work with.
exec: Improve documentation of para_exec_cmdline_pid().2026-07-15T14:22:41ZAndre Nollmaan@tuebingen.mpg.de2026-07-12T19:53:24Zurn:sha1:14d3b8f303fe7ff8ded784161fb14ebf2d840e62
Drop some implementation details and describe the semantics of the pid
pointer in the error case.
exec: Check return value of dup2().2026-07-14T17:53:19ZAndre Nollmaan@tuebingen.mpg.de2026-07-06T21:42:49Zurn:sha1:1128acabb6597e685c899d89a0a67b86e082d7f5
Currently para_exec() ignores all errors from dup2(). Introduce xdup2()
to teach para_exec() to abort on fatal errors and to retry on EINTR.
exec: Invalidate pid if no process was created.2026-07-14T17:42:21ZAndre Nollmaan@tuebingen.mpg.de2026-07-06T21:14:00Zurn:sha1:7652b0d15f11ca3691241fffb9e804cd7dd97baa
If para_exec() fails, it may return with or without writing through the pid
pointer. It's safer to initialize the pid at the beginning of the function
so that pid == 0 iff no process was created.
exec: Drop error message on failure.2026-05-26T11:48:47ZAndre Nollmaan@tuebingen.mpg.de2026-05-24T22:32:31Zurn:sha1:a6a0ae61da3bd565e3c378e5aa1a53c46b48dada
We return the error code, so the caller should act as it sees fit.
Switch to SPDX identifiers.2026-03-17T22:45:43ZAndre Nollmaan@tuebingen.mpg.de2026-03-15T14:57:29Zurn:sha1:ea0cecf96e08c489fdcc94d046019f4ce46f58e2
Generated with
sed -i 's|Copyright.*Andre Noll.*|SPDX-License-Identifier: GPL-2.0 */|g' *.c *.h
followed by manually tweaking the result a bit. No license change intended.
Include regex.h from para.h.2025-05-19T17:35:58ZAndre Nollmaan@tuebingen.mpg.de2025-05-18T20:05:45Zurn:sha1:67388cd4fae0cfd1674aada937f4f4d2faeeee1f
Every .c file includes it anyway.
exec: Improve documentation.2025-01-02T18:35:54ZAndre Nollmaan@tuebingen.mpg.de2025-01-01T20:21:08Zurn:sha1:ca4cb7171c4a391d22af105eb2f9a750e64ac8ea
Clarify the documentation of the public para_exec_cmdline_pid()
and dedox the static para_exec().
gui: Kill also child processes of external commands.2024-12-25T20:08:32ZAndre Nollmaan@tuebingen.mpg.de2024-08-19T19:41:23Zurn:sha1:0deae8543d24cda974b0b7bbbb5be2a924ceef21
When a command is executed as a display command from para_gui, and
the command is interrupted from within para_gui by pressing any key,
para_gui only kills the spawned process but leaves alone its child
processes.
Address this problem by putting the spawned process into a separate
process group so that we can easily kill all processes of the group
by passing the negated PID of the child to kill(2).
In theory, the change in exec.c also affects para_mixer, which executes
para_client and para_audioc. However, para_mixer never kills any of
its child processes.