paraslash/filter_common.c, branch pu

Switch to SPDX identifiers.

2026-03-17T22:45:43Z

Generated with sed -i 's|Copyright.*Andre Noll.*|SPDX-License-Identifier: GPL-2.0 */|g' *.c *.h followed by manually tweaking the result a bit. No license change intended.

Include regex.h from para.h.

2025-05-19T17:35:58Z

Every .c file includes it anyway.

Return from filter_setup() so callers can reset the terminal.

2024-05-26T16:24:22Z

This function of filter_common.c calls exit(3) on errors. This is OK for para_filter and para_audiod, but not for para_play because there the function is called after readline has initialized the terminal for its own use. If the function calls exit(3), the terminal settings are not reset as they should have been. This can be observed for example on the attempt to open an mp3 file with an para_play executable that lacks mp3 support. This commit changes the function to return an error code instead and deals with the fallout in the three callers. Although play.c already had error checking for calls to filter_setup(), it still needs a minor tweak because we now have to deal with the fact that the filter and writer node don't exist in eof_cleanup().

filter_common: Annotate possible NULL pointer confusion.

2024-05-26T16:12:45Z

We know at this point that filter_num is good, so filter_get() returns non-NULL. But gcc-13's static analyzer does not see this and warns. The added assertion makes the warning go away and tells the reader that f == NULL is impossible here.

Rename ->{pre,post}_select methods to ->{pre,post}_monitor.

2022-08-25T13:37:26Z

The word "monitor" is neutral and continues to be correct after the switch from select(2) to poll(2). Pure rename, nothing to see here.

Consolidate receiver/filter/writer {pre,post}_select() docs.

2022-08-25T13:37:26Z

The documentation of these three ->pre_select() and ->post_select() methods overlapped quite a bit. Some comments stated general properties of the sched API which fit better in the documentation of sched.h, so move these bits there. Improve the text a bit while at it and avoid talking about select(2) and fd sets as these are implementation details. Instead, focus on the general concept of fd monitoring. Pure comment cleanups, no code changes.

Shorten copyright notice.

2017-09-22T14:35:22Z

The GPLv2 line does not add any additional information, so drop it. This leaves a single line of legalese text for most files, which is about the amount of screen real estate it deserves. This patch was created with the following script (plus some manual fixups): awk '{ if (NR <= 5) { gs = gensub(/.*Copyright.* ([0-9]+).*Andre Noll.*/, "\\1", "g") if (gs != $0) year = gs next } if (NR == 6 && year != "") printf("/* Copyright (C) %s Andre Noll , see file COPYING. */\n", year) print }'

filter: Simplify FOR_EACH_FILTER().

2017-08-26T19:09:42Z

Use the FILTER_CMD() macro rather than open-coding it.

filter: Handle bad filter numbers gracefully.

2017-06-14T17:54:01Z

This modifies filter_get() to return NULL if an invalid filter number is given, rather than aborting the process. This way applications can loop over all filters without having to include filter_cmd.lsg.h. filter_name(), which also receives a filter number, has no such sanity check and could possibly access uninitialized memory if an invalid argument was passed. This commit adds the check and makes the function return NULL in this case, just like filter_get(). Moreover, the function lacked documentation, so let's add it now.

Convert para_filter to lopsub.

2017-03-26T09:02:28Z

Changes the semantics in case --filter is not given. We used to print an error, but it makes more sense to show the list of supported filters in this case. If no filters are given, we now print the list of available filters. A new function in filter_common.c, print_filter_list(), is introduced for this purpose. The manual page of para_filter has been extended to include an overall description of the command. The only error code of filter.c, E_NO_FILTERS, becomes unused and is removed.