paraslash/stdin.c, branch masterparaslash - network audio streaming toolshttps://git.tue.mpg.de/cgit/paraslash/atom?h=master2026-03-17T22:45:43ZSwitch to SPDX identifiers.2026-03-17T22:45:43ZAndre Nollmaan@tuebingen.mpg.de2026-03-15T14:57:29Zurn:sha1:ea0cecf96e08c489fdcc94d046019f4ce46f58e2
Generated with
sed -i 's|Copyright.*Andre Noll.*|SPDX-License-Identifier: GPL-2.0 */|g' *.c *.h
followed by manually tweaking the result a bit. No license change intended.
Fix some doxygen comments related to stdin and stdout.2026-02-25T18:26:02ZAndre Nollmaan@tuebingen.mpg.de2026-02-18T18:12:34Zurn:sha1:769f4fcfb7e48a277f01195acb07bd75d0a410a0Fix two stdin/stdout related memory leaks.2025-11-17T16:49:38ZAndre Nollmaan@tuebingen.mpg.de2025-11-16T20:45:33Zurn:sha1:309276d5d8f7a489a5c4701e1c8c1bf08ac81d4f
The moderately recent commit which revamped the stdin/stdout API missed to
patch the client code to call the cleanup functions {stdin,stdout}_free()
introduced by that commit.
Also, both {stdin,stdout}.c missed to remove the buffer tree node in certain
cases. The additional btr_remove_node() calls fix this, and they don't hurt
since this function is idempotent.
Fixes: c30b3cf7b9eb76f6b0a6259a4f630017de804608
Revamp the stdin/stdout API.2025-08-27T17:16:54ZAndre Nollmaan@tuebingen.mpg.de2025-07-09T15:20:42Zurn:sha1:c30b3cf7b9eb76f6b0a6259a4f630017de804608
With the current API it is impossible to free the memory that was allocated
by stdin_task_register() after schedule() returns. This commit replaces the
APIs defined in stdin.h and stdout.h to remove the memory leaks which are
inevitable with the old API. We also make struct stdin_task and stdout_task
opaque because the API users (client.c, filter.c, recv.c and write.c) should
not be able to manipulate the fields of these structures directly.
The new stdout API differs from the new stdin API only in that stdout_new()
needs an additional argument to let the caller pass in a pointer to the
parent buffer tree node. Other than that, the APIs are symmetric.
Use the opportunity to do the non-blocking dance in std{in,out}_new()
and std{in,out}_free() rather than in the post-monitor functions. This
way we may get rid of the silly ->must_set_nonblock_flag boolean of struct
std{in,out}_task.
stdin: Only read from stdin if fd 0 is ready.2025-07-12T19:45:44ZAndre Nollmaan@tuebingen.mpg.de2025-07-09T15:23:52Zurn:sha1:f680355be739ed4e98ed52d1fc44b3805861d004
If fd 0 refers to a tty, this file descriptor is blocking. So make sure we
don't read unless we know that the read operation won't block.
Include regex.h from para.h.2025-05-19T17:35:58ZAndre Nollmaan@tuebingen.mpg.de2025-05-18T20:05:45Zurn:sha1:67388cd4fae0cfd1674aada937f4f4d2faeeee1f
Every .c file includes it anyway.
Rename ->{pre,post}_select methods to ->{pre,post}_monitor.2022-08-25T13:37:26ZAndre Nollmaan@tuebingen.mpg.de2021-10-10T16:10:09Zurn:sha1:e3a7e12639c34fd86d48a072beb48add8c498d09
The word "monitor" is neutral and continues to be correct after the
switch from select(2) to poll(2).
Pure rename, nothing to see here.
stdin/stdout: Streamline documentation of {pre,post}_select().2022-08-25T13:37:26ZAndre Nollmaan@tuebingen.mpg.de2021-10-07T19:22:59Zurn:sha1:a62a0bb8fab75f42a3ae165d85e01fb0b98de056
Don't state the obvious and avoid talking about fd sets.
Hide implementation of para_fd_set().2022-08-25T13:37:26ZAndre Nollmaan@tuebingen.mpg.de2021-10-03T19:52:02Zurn:sha1:bb899fb1a0c279a2890ff30d11bf7aec50fb92ed
This preparatory patch for replacing select() renames para_fd_set()
to sched_fd_set(), moves it to sched.c and makes it static. All
users are modified to call either of the two new public functions
sched_monitor_{read,write}fd() which take a pointer to struct sched
rather than an fd set pointer.
fd: Drop fd_set parameter from read_nonblock() and friends.2022-08-25T13:37:26ZAndre Nollmaan@tuebingen.mpg.de2021-09-30T19:46:58Zurn:sha1:4ddaef74ff8f605a31c499d77fcaaffa7a3708c0
This parameter is not necessary because its only purpose is to
avoid the readv(2) system call in case it would likely return EAGAIN
because we just called select(2) which reported that there is no data
to read. Since the parameter is an obstacle for the conversion of
the code base from select(2) to poll(2), get rid of it for the time
being. If needed we can add back an equivalent optimization which
checks for POLLIN after the conversion.