| Commit message (Collapse) | Author | Age |
| |
|
|
|
| |
This is shorter and conveys enough information. Rename the static para_exec()
as well.
|
| |
|
|
|
| |
Rename in to sbar and sb to vbar, as this is still short but conveys the
meaning of both one-line windows better.
|
| |
|
|
|
| |
This adds another theme for para_gui which displays the artist and title of the
current file using large ascii art characters produced by the figlet(1) utility.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
This replaces the array of struct stat_item_data by a function pointer. The
array approach is still used by the colorful blackness theme, which now
defines its own array in gui_theme.c. This allows the definition of struct
stat_item_data to be private to gui_theme.c.
The "simple" theme now tries to display a suitable string to describe the
current audio file rather than always showing the basename. Drop the server
and audiod status items it used to show. It's called "simple", after all.
Both themes need to align the strings they print, so align_str() has
to become public.
|
| |
|
|
|
|
|
| |
This replaces the separator bar and its associated curses window by a
progress bar, using the characters "▒" and "░". The duration of the
current file is shown next to the bar. The colors of the bar and the duration
are configurable in the theme.
|
| |
|
|
| |
In contrast to what the comment says, this is not printed at startup.
|
| |
|
|
| |
The tabular form of the four tags looks a bit nicer. YMMV.
|
| |
|
|
| |
It's more natural to use the .dflt colors only for color pair 0.
|
| |
|
|
| |
System headers come before local headers.
|
| |
|
|
|
|
|
|
|
| |
There is no point in having an init function for each theme that just
initializes the theme structure with values which are compile-time constant.
Make the array constant and change theme_init() to just set the static
global current_theme_num. Also make current_theme_num unsigned, as we perform
decrement and modulo operations on it.
|
| |\
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Improvements to para_gui
A short series which implements the new clear_bot_win internal gui command. On
top of that follow a bunch of other small improvements. Nothing scary here.
* t/gui:
gui: Drop terminating dummy command from command_list[].
gui: Remove dead post-schedule code.
gui: Drop SIGUSR1 handling.
gui: Ignore SIGINT.
gui: Do not request minimal timeout on notifications.
gui: Drop refresh_window().
gui: Use normal output color for help text.
gui: Show file size in human-readable form.
gui: New internal command: clear_bot_win.
|
| | |
| |
| |
| | |
That's easy to do, and quite useful.
|
| |/
|
|
|
|
|
|
| |
Generated with
sed -i 's|Copyright.*Andre Noll.*|SPDX-License-Identifier: GPL-2.0 */|g' *.c *.h
followed by manually tweaking the result a bit. No license change intended.
|
| |
|
|
| |
The new color scheme is easier to read, and is more pleasant on the eye.
|
| |
|
|
|
|
|
|
|
|
| |
It was observed on a 178 column wide xterm window that for the colorful
blackness theme the amp value shown in the top window of para_gui
wrapped into the subsequent line under some circumstances. Adjust
the corresponding value in gui_theme.c to fix this.
Also add the missing space character to the prefix and fix a whitespace
issue while at it.
|
| |
|
|
|
| |
Without this, on a 80 character window and the three-digit amp value,
the value gets truncated unnecessarily.
|
| |
|
|
|
|
|
|
|
| |
Currently, the first digit of a 4-digit image ID get truncated to
three characters if the width of the terminal window is at its minimal
size of 80 characters. We can squeeze out two more characters from
the previous field, so this is easy to fix.
This only affects the colorful blackness theme.
|
| |
|
|
|
| |
Without this, the contents of the subsequent item (numplayed) are
overwritten by spaces. This only affects the colorful blackness theme.
|
| |
|
|
|
|
|
|
|
| |
If the terminal window is only 80 characters wide, the num_played
value may be adjacent to the bitrate value, with no space between.
This happens only if the num_played value is bigger than 99, and only
with the "colorful blackness" theme.
This simple patch should fix the issue.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The GPLv2 line does not add any additional information, so drop
it. This leaves a single line of legalese text for most files, which
is about the amount of screen real estate it deserves.
This patch was created with the following script (plus some manual
fixups):
awk '{
if (NR <= 5) {
gs = gensub(/.*Copyright.* ([0-9]+).*Andre Noll.*/, "\\1", "g")
if (gs != $0)
year = gs
next
}
if (NR == 6 && year != "")
printf("/* Copyright (C) %s Andre Noll <maan@tuebingen.mpg.de>, see file COPYING. */\n", year)
print
}'
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The only reason the status item enum and string array are defined in
configure.ac is that upper case identifiers and lower case strings
are not easy to do in cpp as it lacks toupper().
However, configure.ac is not the right place for defining C language
constructs as the configure script should only check for installed
packages.
This commit moves the definition of the status item enum and array to
para.h and modifies all users to use lower case for the item names.
This was automated with a script which essentially did
upper=${i^^}
sed -i "s/\<SI_$upper/SI_$i/g" $files
for each status item $i. Care has been taken to leave the order of
the status items unchanged. This is important because the item numbers
must be considered part of the API between server and client.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Done with
files=$(git grep -l 'Copyright (C) [0-9]\{4\}\(-2014\)* Andre Noll')
sed --in-place= -e 's/Copyright (C) \([0-9]\{4\}\)-2014 Andre Noll/Copyright (C) \1 Andre Noll/1' $files
In previous years we ran a similar script to set the second year in
the range to the current year. This is kind of silly, so let's get
rid of this useless information.
This commit replaces "Copyright (C) A-B" by "Copyright (C) A" in
all file headers, i.e. only the first year (A) is left in. Accurate
information including time stamps for each change can be obtained
from the git history.
|
| |
|
|
| |
Quite a few..
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
The mail server on systemlinux.org was down for more than a week
lately, so let's use an alternative official address. This commit
changes all maan@systemlinux.org addresses to maan@tuebingen.mpg.de.
Most .c and .h files contain the email address in the copyright header,
so they must all be patched. Three other files contain the address
for a different reason:
* README lists email and git, gitweb and home page URLs
* configure.ac needs it for configure -h
* version.c contains it for the -V option of all commands
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
Various gui elements of para_gui can be customized through struct
gui_theme. Currently this structure contains two integers for each
each element, one for the foreground and one for the background color
of the element. This is a bit clumsy and repetitive.
This commit cuts down the number of fields of struct gui_theme by
a factor of two by introducing struct gui_color_spec as a pair of
integers.
The patch is quite large but also simple.
|
| |
|
|
|
| |
Now that para_gui is in a much better shape, let's make it a first
class citizen and document all public functions and data structures.
|
| |
|
|
| |
It's silly to have a function for this.
|
| |
|
|
| |
Prefix all functions related to themes with "theme_".
|
| |
|
|
|
|
|
|
|
|
|
|
| |
This should be slightly more efficient.
This patch also changes the type of struct gui_theme->sep_str from
const char * to plain char and renames the field to sep_char. It must
be a single-character string anyway.
For the colorful blackness theme we now use the default character
from curses.h rather than '-'. This looks nicer. Tested with ncurses
on Linux and the curses implementation that ships with NetBSD.
|
| |
|
|
|
|
|
| |
The only information shown by print_welcome() that is not already
contained in the status bar is the name of the current theme. This
is not very interesting, so remove the function and the corresponding
color pair.
|
| |
|
|
|
|
|
|
|
| |
This year, we're really on time. The changes in this patch were
created by the following silly script:
files=$(git grep -l 'Copyright (C) [0-9]\{4\}\(-2013\)* Andre Noll')
sed --in-place= -e 's/Copyright (C) \([0-9]\{4\}\)-2013 Andre Noll/Copyright (C) \1-2014 Andre Noll/1' $files
sed --in-place= -e 's/Copyright (C) 2013 Andre Noll/Copyright (C) 2013-2014 Andre Noll/1' $files
|
| |
|
|
| |
Better late than never.
|
| | |
|
| |
|
|
|
|
|
|
|
| |
This adds the #include statement for stdbool.h to para.h. This allows
to get rid of the individual includes in *.c.
More importantly, since all *.c files include para.h, booleans will
now be available everywhere so that we won't need to touch dozens of
files anymore whenever a boolean is added to a public structure.
|
| |
|
|
| |
Found by sparse.
|
| | |
|
| |
|
|
|
| |
This implements the --theme option which allows to start para_gui
with a theme different than the default theme.
|
| | |
|
| |
|
|
| |
Hey, this is earlier than last year :)
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The main change is the replacement of afhi->taginfo by more specific
fields: This patch adds struct taginfo to the audio format handler
info struct.
The prefix is no longer stored inside the osl database, i.e. it is
no longer duplicated for each audio file.
The tag information is only stored in memory as a dynamically allocated
string if it is new, i.e. if the struct was generated by the audio format
handler. If it was retrieved from the database, pointers to the memory
mapped table are used instead.
The crappy fixup_info_string() function is gone. It was too ugly to live.
Of course, this re-introduces the bug it fixed, but as we broke the
on disk format with this patch anyway, we might as well fix it right(TM).
This will be done in a subsequent patch.
afhi->eof_tv is gone as well. It was not useful at all.
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
|
|
| |
SI_LENGTH_MIN -> SI_BITRATE
SI_LENGTH_SEC -> SI_FREQUENCY
SI_ATTRIBUTES -> SI_ATTRIBUTES_BITMAP
SI_UPTIME -> SI_ATTRIBUTES_TXT
|
| |
|
|
|
|
|
|
| |
SI_AUDIO_INFO1 -> SI_AUDIO_FILE_INFO
SI_AUDIO_INFO2 -> SI_TAG_INFO1
SI_AUDIO_INFO3 -> SI_TAG_INFO2
The mp3 and the ogg afh stored bits of information in the info
string. Only store there what is not already contained in afh_info.
|